Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-23 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127866/#review95728 --- +1 from me - looks much better without the while loops indeed

Re: Review Request 127823: Allow building without strigi on Linux

2016-05-23 Thread Johannes Huber
> On Mai 3, 2016, 2:58 nachm., Aleix Pol Gonzalez wrote: > > Why touch the `if(WIN32)` though? If needed, just make it optional on all > > platforms. > > Antonio Rojas wrote: > That's what I'm doing... Currently it's only optional on WIN32, I'm > changing it to be optional regardless of th