Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. Now I see that

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. ah now I see. You adjusted the test application, but not the autotest. - Martin ---

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95535 --- The test does not verify the problem. I just pulled the patch

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
> On May 17, 2016, 2:35 p.m., Martin Gräßlin wrote: > > The change looks sensible to me, but I would appreciate a test case for it. > > There are already some tests for the file dialog, so it should be easy to > > extend. There is no autotest, but have updated tests/qfiledialogtest with option

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 17, 2016, 3:20 p.m.) Review request for kde-workspace and Pl

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95533 --- Ship it! This would fix https://bugs.kde.org/show_bug.cgi?

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95532 --- The change looks sensible to me, but I would appreciate a tes

Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- Review request for kde-workspace and Plasma. Bugs: 360666 https://bug

Re: File overwrite warning missing?

2016-05-17 Thread Boudewijn Rempt
This looks like a real kf5 bug, since it was just reproduce for Konsole. On Tue, 17 May 2016, Boudewijn Rempt wrote: Hi, Users with the latest plasma/frameworks who build Krita themselves are reporting that the file dialog no longer warns about overwriting existing files: https://bugs.kde.org