Re: Minuet (music education software) moved to kdereview

2016-01-25 Thread Albert Astals Cid
El Monday 25 January 2016, a les 21:47:34, Albert Astals Cid va escriure: > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > > Hi Sandro, it is always great when such a cool application lands in KDE > > Edu. I just made a first and rough (since I do not have all depe

Re: Minuet (music education software) moved to kdereview

2016-01-25 Thread Albert Astals Cid
El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > * it looks strange to me that in minuet/cmake/ there are Config-files for > the 3rd-party library drumstick. My understanding was that such Config > files should only be shipped with the respective library (maybe someon

Re: Minuet (music education software) moved to kdereview

2016-01-25 Thread Albert Astals Cid
El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > Hi Sandro, it is always great when such a cool application lands in KDE Edu. > I just made a first and rough (since I do not have all dependencies yet to > really compile and test it) code review. > > Here a some minor

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/#review91568 --- Ship it! on the fence about this. it's a rename of a semi

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-25 Thread Martin Gräßlin
> On Jan. 23, 2016, 6:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th