Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Elvis Angelaccio
2016-01-24 18:57 GMT+01:00 Andreas Cord-Landwehr : > On Sunday, January 24, 2016 6:47:17 PM CET Elvis Angelaccio wrote: > > 2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > > also in the main.cpp there should be a call to "KCrash::initialize();" > > > > Shouldn't this happen automatically? >

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Elvis Angelaccio
2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > also in the main.cpp there should be a call to "KCrash::initialize();" Shouldn't this happen automatically? This is what the documentation at [1] seems to imply, at least. >From a quick search on LXR, it looks like very few apps call explic

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Andreas Cord-Landwehr
On Sunday, January 24, 2016 6:47:17 PM CET Elvis Angelaccio wrote: > 2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > also in the main.cpp there should be a call to "KCrash::initialize();" > > Shouldn't this happen automatically? > This is what the documentation at [1] seems to imply, at lea

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Andreas Cord-Landwehr
Hi Sandro, it is always great when such a cool application lands in KDE Edu. I just made a first and rough (since I do not have all dependencies yet to really compile and test it) code review. Here a some minors I noticed: * the application does not link against KCrash (which is needed for DrKonq

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Thomas Pfeiffer
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Thomas Lübking
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: State of Proposal to improving KDE Software Repository Organization?

2016-01-24 Thread Albert Astals Cid
El Monday 18 January 2016, a les 20:27:16, Boudewijn Rempt va escriure: > On Mon, 18 Jan 2016, Friedrich W. H. Kossebau wrote: > > Reason that I ask is that due to the split of Calligra into several repos > > (see background^) the layout in the repo structure does no longer > > properly reflect the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 24, 2016, 11:09 a.m.) Review request for KDE Base Apps, Mar

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th