Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-13 Thread Andrey Bondrov
> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote: > > All in all it looks quite good. > > > > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that > > overrides some methods (you can add virtuals). Otherwise we're adding > > weirdly specific logic. > > > > Also I'd

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-13 Thread Andrey Bondrov
> On Янв. 13, 2016, 12:31 д.п., Aleix Pol Gonzalez wrote: > > src/iconthemesmodel.cpp, line 99 > > > > > > Now that you have the CursorsThemeModel that shouldn't be needed > > anymore. > > > > If it stil