Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 13, 2016, 6:03 д.п.) Review request for kde-workspace, Alei

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90985 --- src/iconthemesmodel.cpp (line 54)

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote: > > All in all it looks quite good. > > > > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that > > overrides some methods (you can add virtuals). Otherwise we're adding > > weirdly specific logic. > > > > Also I'd

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 12, 2016, 3:53 п.п.) Review request for kde-workspace, Alei

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 12, 2016, 3:49 п.п.) Review request for kde-workspace, Alei

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote: > > All in all it looks quite good. > > > > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that > > overrides some methods (you can add virtuals). Otherwise we're adding > > weirdly specific logic. > > > > Also I'd

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90964 --- All in all it looks quite good. I'd suggest creating a Cursor

Re: KDE Frameworks 5.18.0 released

2016-01-12 Thread Andreas Müller
On Sat, Jan 9, 2016 at 1:41 PM, David Faure wrote: > 09th January 2016. KDE today announces the release of KDE Frameworks 5.18.0. > > KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of· > commonly needed functionality in mature, peer reviewed and well tested· > libraries w