Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-23 Thread René J . V . Bertin
> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-23 Thread Thomas Lübking
> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-23 Thread Thomas Lübking
> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-23 Thread René J . V . Bertin
> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Policy regarding QtWebKit and QtScript

2015-12-23 Thread Christoph Cullmann
Hi, >> Isn't the designated successor for QtScript QJSEngine >> (I even assumed there should be some porting tools?) > > That's what I meant under 'qml engines'. :) > > A relevant mail by Frederik: > http://lists.qt-project.org/pipermail/interest/2015-June/017446.html for KTextEditor: 1) kross

Re: Policy regarding QtWebKit and QtScript

2015-12-23 Thread Thiago Macieira
On Wednesday 23 December 2015 00:06:18 Luigi Toscano wrote: > Shouldn't it be the other way around? Workable solution first and drop the > old one later? The big problem of keeping qtwebkit in the 5.6 release is that it would need to be supported for the 3 years of the long term support release a

Re: Policy regarding QtWebKit and QtScript

2015-12-23 Thread Thiago Macieira
On Tuesday 22 December 2015 16:07:06 Lisandro Damián Nicanor Pérez Meyer wrote: > IIRC Thiago said that it didn't use private stuff, so recompiling should be > more than enough (in case it is really needed). I might be wrong. But that's the kind of breakage that is easily caught before Qt relea