Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125613/#review87278 --- I was about to commit this but i guess this also needs to be a

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread Alberto Jiménez Ruiz
> On Oct. 22, 2015, 7:11 a.m., David Faure wrote: > > The fix looks fine to me now, thanks. The unittest can be improved a bit, > > feel free to commit after making the changes suggested below (or tell me if > > you have no account) I don't have an account to commit the changes. Improved the

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread Alberto Jiménez Ruiz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125613/ --- (Updated Oct. 22, 2015, 7:31 a.m.) Review request for kdelibs, Albert Ast

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125613/#review87242 --- Ship it! The fix looks fine to me now, thanks. The unittest c