Re: Review Request 125529: switch kde4libs defaults from oxygen to breeze

2015-10-05 Thread Harald Sitter
> On Oct. 5, 2015, 2:46 p.m., Hrvoje Senjan wrote: > > As this is a behvioral change (well, closest categorisation), i would avoid > > merging this to kdelibs4, and mail kde-distro-packagers with a link to this > > review instead ;-) Yeah, I pretty much agree but I thought I'd post it all the

Re: Review Request 125529: switch kde4libs defaults from oxygen to breeze

2015-10-05 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125529/#review86378 --- As this is a behvioral change (well, closest categorisation),

Review Request 125529: switch kde4libs defaults from oxygen to breeze

2015-10-05 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125529/ --- Review request for kdelibs and Jonathan Riddell. Repository: kdelibs De

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-05 Thread Elvis Angelaccio
> On Oct. 5, 2015, 8:23 a.m., Vishesh Handa wrote: > > Is the 'Ship it' by accident, I guess? This patch does not currently compile. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/#review86362 --- Ship it! app/addToArchiveDndPlugin.cpp (line 38)