Review Request 125056: Fix build on OS X

2015-09-04 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125056/ --- Review request for kde-workspace and Jonathan Riddell. Repository: kwalle

Review Request 125055: Fix build on OS X

2015-09-04 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125055/ --- Review request for kde-workspace and Jonathan Riddell. Repository: user-m

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Thomas Lübking
> On Sept. 4, 2015, 1:38 nachm., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going f

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
> On Sept. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Martin Klapetek
> On Sept. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
> On Sept. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Luigi Toscano
> On Set. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Jeremy Whiting
> On Sept. 4, 2015, 7:38 a.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
> On Sept. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Luigi Toscano
> On Set. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
> On Sept. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
> On Sept. 4, 2015, 3:21 p.m., Thomas Lübking wrote: > > kcontrol/input/mouse.cpp, line 184 > > > > > > read this line closely, then fix it ;-P Oops :) But I guess that answers my question whether the change ha

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125043/ --- (Updated Sept. 4, 2015, 4:22 p.m.) Review request for KDE Software on Mac

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125043/#review84821 --- You are aware that this is a dead repo and that this is a new

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Luigi Toscano
> On Set. 4, 2015, 3:21 p.m., Thomas Lübking wrote: > > kcontrol/input/kmousedlg.ui, line 82 > > > > > > You *must* ask the i18n team about this (requires an exception) on > > kde-...@kde.org > > > > Sin

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125043/#review84822 --- hmm, looks like a feature in a now frozen repo, not sure is a

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125043/#review84819 --- kcontrol/input/kmousedlg.ui (line 82)

Re: Porting to frameworks 2: libkcompactdisc

2015-09-04 Thread Friedrich W. H. Kossebau
Am Freitag, 4. September 2015, 02:28:49 schrieb Alexander Potashev: > 2015-09-04 0:49 GMT+03:00 Jeremy Whiting : > > Second project I took a quick stab at libkcompactdisc which > > audiocd-kio will need (which amarok will need for playing audio cds > > once it's ported to qt5/kf5 too). I pushed to

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125043/#review84816 --- kcontrol/input/mouse.cpp (lines 183 - 185)

Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125043/ --- Review request for KDE Software on Mac OS X, kde-workspace and kdelibs. R

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-04 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-04 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b