Re: Best-practise currently for testing internal parts of libs? *_TEST_EXPORT macro?

2015-09-02 Thread Friedrich W. H. Kossebau
Hi Kevin, Jeremy & David, thanks all for your replies so far, gives me/us a palette to chose from, nice :) Seems exporting symbols only for testing is not a great no-go with known big traps, okay. So no need to port away from that tomorrow. So... below: Am Montag, 31. August 2015, 18:54:19 sc

Re: Best-practise currently for testing internal parts of libs? *_TEST_EXPORT macro?

2015-09-02 Thread Friedrich W. H. Kossebau
Am Mittwoch, 2. September 2015, 11:20:19 schrieb David Faure: > On Monday 31 August 2015 14:41:00 Friedrich W. H. Kossebau wrote: > > The only place lxr.kde.org pointed out to use the *TEST_EXPORT approach > > was > > grantlee, which simply creates a separate file with the define that then > > is >

Re: Best-practise currently for testing internal parts of libs? *_TEST_EXPORT macro?

2015-09-02 Thread Friedrich W. H. Kossebau
Am Montag, 31. August 2015, 09:26:52 schrieb Thiago Macieira: > On Monday 31 August 2015 14:41:00 Friedrich W. H. Kossebau wrote: > > #ifdef COMPILING_TESTS > > #if defined _WIN32 || defined _WIN64 > > Remove the Windows check. The next lines are valid outside of Windows too > and should be used o

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https:/

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https:/

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread René J . V . Bertin
> On Sept. 2, 2015, 3:06 p.m., Dominik Haumann wrote: > > Since this is a mac issue, what about this: > > > > if (e->modifiers() == Qt::ControlModifier > > #ifdef Q_OS_MAC > > && KGlobalSettings::wheelMouseZooms() > > #endif > > ) { // ... > > > > That way we at least do

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120319/#review84760 --- Since this is a mac issue, what about this: if (e->modifi

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Best-practise currently for testing internal parts of libs? *_TEST_EXPORT macro?

2015-09-02 Thread David Faure
On Monday 31 August 2015 14:41:00 Friedrich W. H. Kossebau wrote: > > The only place lxr.kde.org pointed out to use the *TEST_EXPORT approach was > grantlee, which simply creates a separate file with the define that then is > appended to the file generated with generate_export_header: > http://l