---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125010/
---
Review request for kdelibs and David Faure.
Repository: kde-baseapps
De
On Monday 31 August 2015 09:29:52 Jeremy Whiting wrote:
> The way the knewstuff tests work is by linking the source files being
> tested directly. For example the Entry test also links entry.cpp and
> entry.h directly. This way it doesn't need to have Entry private
> methods exported at all. This m
On Monday 31 August 2015 14:41:00 Friedrich W. H. Kossebau wrote:
> #ifdef COMPILING_TESTS
> #if defined _WIN32 || defined _WIN64
Remove the Windows check. The next lines are valid outside of Windows too and
should be used on all platforms.
If and when I change Q_DECL_EXPORT to be protected visi
The way the knewstuff tests work is by linking the source files being
tested directly. For example the Entry test also links entry.cpp and
entry.h directly. This way it doesn't need to have Entry private
methods exported at all. This may or may not be the best way to do it
though, but has worked ok
Hi,
what approach is best-practise currently for testing internal parts of libs?
E.g. by symbols (classes) are not exported by default?
In Calligra we have code that uses XYZ_TEST_EXPORT macros for those symbols
which should be only exported in test-enabled builds, e.g. by defining
COMPILING_T
