> On Aug. 19, 2015, 6:06 p.m., Stephen Kelly wrote:
> > This patch is not correct.
> >
> > What repo were you trying to build? Add cmake_minimum_required(VERSION
> > 2.8.9) there.
>
> Stephen Kelly wrote:
> Why did this review go quiet? Did you pull and realize that line was
> already th
El Dijous, 20 d'agost de 2015, a les 17:16:40, Thiago Macieira va escriure:
> On Friday 21 August 2015 01:45:12 Albert Astals Cid wrote:
> > So with your new patches and https://git.reviewboard.kde.org/r/124856/ i
> > can run konsole fine both with --nofork and in the normal mode.
>
> It wasn't r
> On Aug. 19, 2015, 8:06 p.m., Stephen Kelly wrote:
> > This patch is not correct.
> >
> > What repo were you trying to build? Add cmake_minimum_required(VERSION
> > 2.8.9) there.
>
> Stephen Kelly wrote:
> Why did this review go quiet? Did you pull and realize that line was
> already th
> On Ago. 19, 2015, 8:06 p.m., Stephen Kelly wrote:
> > This patch is not correct.
> >
> > What repo were you trying to build? Add cmake_minimum_required(VERSION
> > 2.8.9) there.
>
> Stephen Kelly wrote:
> Why did this review go quiet? Did you pull and realize that line was
> already th
> On Aug. 19, 2015, 8:06 p.m., Stephen Kelly wrote:
> > This patch is not correct.
> >
> > What repo were you trying to build? Add cmake_minimum_required(VERSION
> > 2.8.9) there.
>
> Stephen Kelly wrote:
> Why did this review go quiet? Did you pull and realize that line was
> already th
> On Aug. 19, 2015, 6:06 p.m., Stephen Kelly wrote:
> > This patch is not correct.
> >
> > What repo were you trying to build? Add cmake_minimum_required(VERSION
> > 2.8.9) there.
Why did this review go quiet? Did you pull and realize that line was already
there in whatever repo you're looki