Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread René J . V . Bertin
> On Aug. 19, 2015, 11:14 p.m., Heiko Becker wrote: > > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > > > > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961976060d872faffb > > René J.V. Bertin wrote: > Well, IMVHO it's fine t

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread René J . V . Bertin
> On Aug. 19, 2015, 11:14 p.m., Heiko Becker wrote: > > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > > > > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961976060d872faffb Well, IMVHO it's fine to impose upgrading to the latest c

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Rolf Eike Beer
Am Mittwoch, 19. August 2015, 21:14:38 schrieb Heiko Becker: > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961 > 976060d872faffb But the short fix for this is indeed to put cmake_minimum_

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84069 --- I stumbled upon the same, it's actually a bug in cmake fixed b

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Stephen Kelly
> On Aug. 19, 2015, 6:03 p.m., Jeremy Whiting wrote: > > Ship It! Don't ship it :). - Stephen --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84061

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84062 --- This patch is not correct. What repo were you trying to buil

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84061 --- Ship it! Ship It! - Jeremy Whiting On Aug. 19, 2015, 11:41

Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdel

Re: Plasma Applet for Audio Volume for kdereview

2015-08-19 Thread Manuel Mommertz
Am Dienstag, 18. August 2015, 10:05:30 schrieb Mark Gaiser: > On Mon, Aug 17, 2015 at 3:10 PM, Sebastian Kügler wrote: > > I think we should be peachy now. Can plasma-pa be moved from kdereview to > > kde/workspace? > > Just my opinion as a plasma 5 user. > Yes, please! Kmix was great under KDE 4