Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Jarosław Staniek
Thiago Macieira wrote: > On Friday 14 August 2015 14:34:49 Jarosław Staniek wrote: >> I also think we agree that anything other than 0 is good for readability >> and readability should be the priority. > > Note that the Qt 5.7 policy still allows and even asks for use of 0 as > null in some plac

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Thiago Macieira
On Friday 14 August 2015 04:07:41 Thomas Lübking wrote: > We could just detect the compiler, and in need define nullptr 0x0, look the > other side and hope for the best (ie. anybody on modern compilers anyway > and nobody actually making use of std::nullptr_t atm. but just of the > keyword) - not v

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Thomas Lübking
On Freitag, 14. August 2015 22:34:28 CEST, Thiago Macieira wrote: Don't do that. If you use nullptr, there's no going back to zero because it's not the same. You've irrevocably locked yourself into requiring a compiler that supports it. Even if it's only been used in a 0x0 "compliant" way? S

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Thiago Macieira
On Friday 14 August 2015 14:34:49 Jarosław Staniek wrote: > I also think we agree that anything other than 0 is good for readability > and readability should be the priority. Note that the Qt 5.7 policy still allows and even asks for use of 0 as null in some places. The policy is: * always use

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Ivan Čukić
> I would have said the docs or the wiki somewhere, but I've just discovered > that the docs are wrong... :-) Heh, I had the same approach. :) -- Cheerio, Ivan

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Thiago Macieira
On Friday 14 August 2015 08:28:51 Ivan Čukić wrote: > > It isn't. The page is just plainly wrong. > > In that case, I retract my previous comments. Where are the *proper* > requirements documented then (for future reference)? > > > That's the list of platforms the Qt CI tests on. > > It lists bo

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Allen Winter
On Friday, August 14, 2015 02:34:49 PM Jarosław Staniek wrote: > > PS: A Krazy check checking for usage of NULLs and Q_NULLPTR would be lovely. > Checking the use of 0's isn't easy, right? > Already done, since 2007. but it's in the "extra" checkers, ie. not enabled by default. Currently the

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Jarosław Staniek
Sergio Martins wrote: > https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 > states gcc 4.5 as the minimum version, meaning we can't use nullptr. > > However, since some time now, kf5 libraries are full of nullptr (~400 > occurrences) and nobody noticed.

Re: Plasma Applet for Audio Volume for kdereview

2015-08-14 Thread Jan Kundrát
On Thursday, 6 August 2015 12:43:28 CEST, Martin Klapetek wrote: You can still use kmix with Plasma, there is even a port to kf5 though I'm not sure what's its state. FYI, I've been running with the KF5 kmix for a couple of months without any issues. I'm using just plain old ALSA, not PA. Ch

What to do with our default hidden visibility for symbols?

2015-08-14 Thread Jaroslaw Staniek
Hi, ECM's KDECompilerSettings.cmake contains: # Default to hidden visibility for symbols set(CMAKE_CXX_VISIBILITY_PRESET hidden) set(CMAKE_VISIBILITY_INLINES_HIDDEN 1) This raises a warning [1] for CMake 3.3+ and ignores this. Don't we want to set the old policy ​CMP0063 for now? Or even prepa