Re: KScreenGenie moved to KDE Review

2015-06-29 Thread Boudhayan Gupta
Hi Thomas, On 29 June 2015 at 19:30, Thomas Lübking wrote: > It's because eg. you use the "Apply" role for "Save & Exit" (would rather be > "Ok" role) and "Discard" for "Discard", while the latter actually acts as > "Cancel" ("reject", not "reset and exit" - there's nothing to reset in the > firs

Re: KScreenGenie moved to KDE Review

2015-06-29 Thread Thomas Lübking
On Montag, 29. Juni 2015 11:58:29 CEST, Boudhayan Gupta wrote: Hi Thomas, It's a standard QDialogButtonBox. I haven't set the button ordering manually at all. Maybe it's a QDialogButtonBox bug then. It's because eg. you use the "Apply" role for "Save & Exit" (would rather be "Ok" role) and "

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-29 Thread Milian Wolff
On Friday 26 June 2015 03:17:49 Vishesh Handa wrote: > On Wed, Jun 24, 2015 at 9:52 AM, Milian Wolff wrote: > > Hm, so maybe related to https://git.reviewboard.kde.org/r/124128/ ? > > > > Vishesh, did you also see similar freezes? > > I didn't actually get the freezes, but David Edmunson was get

Re: KScreenGenie moved to KDE Review

2015-06-29 Thread Boudhayan Gupta
Hi Thomas, On 29 June 2015 at 03:44, Thomas Lübking wrote: > Did a functional test only. > > a) The button role assignment seems wrong (you tried to arrange buttons in a > certain order that suits either the KDE or windows order? They end up > totally weird other orders eg. GTK or OSX) > It's a