Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Patrick Eigensatz
> On Mai 18, 2015, 7:28 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 92 > > > > > > Not sure if *text.isEmpty()* returns true if text=="\n\t \n" > > > > QT Documentation says: "Retur

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Thomas Lübking
> On Mai 18, 2015, 7:28 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 92 > > > > > > Not sure if *text.isEmpty()* returns true if text=="\n\t \n" > > > > QT Documentation says: "Retur

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Thomas Pfeiffer
> On May 17, 2015, 6:22 p.m., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differently

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80603 --- klipper/historyitem.cpp (line 92)

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/ --- (Updated Mai 18, 2015, 7:25 nachm.) Review request for kde-workspace, KDE

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Martin Gräßlin
> On May 17, 2015, 8:22 p.m., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differently

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Patrick Eigensatz
> On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differentl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Thomas Lübking
> On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differentl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Patrick Eigensatz
> On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differentl

Re: Extended handling of magnet links

2015-05-18 Thread Albert Astals Cid
El Dissabte, 16 de maig de 2015, a les 21:31:49, Vladimir Perepechin va escriure: > Hi everyone :) > > I was thinking about implementing my idea > https://forum.kde.org/viewtopic.php?f=83&t=126352 . > While digging sources i've understand that my idea was incorrect, and there > is nothing to do w

Re: Porting to KF5 - kimageio question

2015-05-18 Thread Albert Astals Cid
El Dilluns, 18 de maig de 2015, a les 08:00:07, Martin Koller va escriure: > On Sunday 10 May 2015 19:39:07 Alex Merry wrote: > > On Saturday 09 May 2015 22:54:49 Martin Koller wrote: > > > I'm working on porting kolourpaint to kf5. > > > Now I find the following: > > > KDELIBS4SUPPORT_DEPRECATED_E

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Thomas Lübking
> On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differentl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Martin Gräßlin
> On May 16, 2015, 11:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options