Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Thomas Pfeiffer
> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't c

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Thomas Pfeiffer
> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't c

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80490 --- klipper/historyitem.cpp (line 91)

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/ --- (Updated Mai 16, 2015, 9:31 nachm.) Review request for kde-workspace, KDE

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Thomas Lübking
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Heiko Tietze
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Heiko Tietze
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/ --- (Updated Mai 16, 2015, 6:11 nachm.) Review request for kde-workspace, KDE

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Christoph Feck
> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't c

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80466 --- klipper/klipper.kcfg (line 32)

Extended handling of magnet links

2015-05-16 Thread Vladimir Perepechin
Hi everyone :) I was thinking about implementing my idea https://forum.kde.org/viewtopic.php?f=83&t=126352 . While digging sources i've understand that my idea was incorrect, and there is nothing to do with kio_magnet. My second thought was to store any additional info in mimeinfo while detecting

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80463 --- klipper/configdialog.cpp (line 50)

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/ --- (Updated Mai 16, 2015, 12:40 nachm.) Review request for kde-workspace, KD

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/ --- (Updated Mai 16, 2015, 11:44 vorm.) Review request for kde-workspace, KDE

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Heiko Tietze
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Patrick Eigensatz
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Martin Gräßlin
> On May 15, 2015, 9:31 p.m., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Heiko Tietze
> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t