Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated April 17, 2015, 8:33 a.m.) Review request for KDE Base Apps, Mar

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote: > > I'm still not sure about the text for the message box: could you please add > > Thomas Pfeiffer from Usability team to the review to get him comment on it? > > Gregor Mi wrote: > Sure. I'll add him. I updated the text. Message box

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 16, 2015, 3:14 nachm., Martin Gräßlin wrote: > > processui/ksysguardprocesslist.cpp, line 359 > > > > > > You could know whether kwin is used - the window manager name is > > exported to the root wind

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 16, 2015, 3:14 p.m., Martin Gräßlin wrote: > > processui/ksysguardprocesslist.cpp, line 359 > > > > > > You could know whether kwin is used - the window manager name is > > exported to the root window

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 16, 2015, 3:14 nachm., Martin Gräßlin wrote: > > processui/ksysguardprocesslist.cpp, line 359 > > > > > > You could know whether kwin is used - the window manager name is > > exported to the root wind

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 16, 2015, 3:14 p.m., Martin Gräßlin wrote: > > processui/ksysguardprocesslist.cpp, line 359 > > > > > > You could know whether kwin is used - the window manager name is > > exported to the root window

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote: > > I'm still not sure about the text for the message box: could you please add > > Thomas Pfeiffer from Usability team to the review to get him comment on it? Sure. I'll add him. - Gregor

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review79097 --- I'm still not sure about the text for the message box: could y

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On April 16, 2015, 3:14 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 22-33 > > > > > > do we still need all those? I only see GlobalAccel used as a new > > dependency or am I missing something? Previo

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated April 17, 2015, 7:25 a.m.) Review request for KDE Base Apps, Mar