Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated March 13, 2015, 10:08 p.m.) Review request for KDE Base Apps, Ma

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Thomas Lübking
> On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Thomas Lübking
> On März 2, 2015, 7:47 vorm., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated March 13, 2015, 7:27 p.m.) Review request for KDE Base Apps, Mar

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated March 13, 2015, 7:29 p.m.) Review request for KDE Base Apps, Mar

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Martin Gräßlin
> On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Martin Gräßlin
> On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Martin Gräßlin
> On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-13 Thread Gregor Mi
> On March 2, 2015, 7:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *

Re: Review request: QBluez

2015-03-13 Thread David Rosca
> Do you expect the bluez-qt branch of bluedevil to be ready to merge before > Plasma 5.3 freeze on Thu 9 April? Currently, this branch is old and still using old name qbluez. I will update it and work on it in next days to make it ready for Plasma 5.3. David On Thu, Mar 12, 2015 at 8:26 PM, Jo

Re: Review request: QBluez

2015-03-13 Thread David Rosca
Done. It's in kdereview now: https://projects.kde.org/projects/kdereview/bluez-qt David

Re: Review Request 122922: Remove two asserts from kzip.cpp

2015-03-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122922/ --- (Updated March 13, 2015, 8:34 a.m.) Status -- This change has been m

KDE Frameworks 5.8 released

2015-03-13 Thread David Faure
New frameworks: * KPeople, provides access to all contacts and the people who hold them * KXmlRpcClient, interaction with XMLRPC services ### General * A number of build fixes for compiling with the upcoming Qt 5.5 ### KActivities * Resources scoring service is now finalized ### KArchive * St