Re: Review request: QBluez

2015-03-12 Thread Jonathan Riddell
On Thu, Mar 12, 2015 at 08:23:22PM +0100, David Rosca wrote: > Done. It's in kdereview now: > https://projects.kde.org/projects/kdereview/bluez-qt Woo, lovely. Best post to plasma-devel about that (it's been posted around lots already but best to cover all the bases I guess.) Do you expect the b

Review Request 122922: Remove two asserts from kzip.cpp

2015-03-12 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122922/ --- Review request for kdelibs. Bugs: 343214 http://bugs.kde.org/show_bug

Re: Review request: QBluez

2015-03-12 Thread Jonathan Riddell
Please file a sysadmin request to move it into kdereview, then after a couple of weeks if there's no objections it can be moved into kde/workspace (for plasma). Jonathan

Re: [kde-frameworks-devel] Review request: QBluez

2015-03-12 Thread David Rosca
On Wed, Mar 11, 2015 at 6:49 PM, Jonathan Riddell wrote: > The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how > about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-03-12 Thread Martin Gräßlin
> On March 2, 2015, 8:47 a.m., Martin Gräßlin wrote: > > processui/keyboardshortcututil.cpp, line 46 > > > > > > This looks to complicated. It should be much easier to do with the > > KGlobalAccel API: > > *