Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review76861 --- processui/keyboardshortcututil.cpp

Re: [KDE/Mac] Multiplatform frameworks

Hi René, On 01/03/2015, at 8:17 PM, René J.V. Bertin wrote: > On Sunday March 01 2015 17:37:35 Ian Wadham wrote: >> Let me kick off by saying that I am not necessarily in favour of "doing what >> the Romans do"… ;-) > > Heh, I got that! :) Yeah, but I am keeping an open mind… >> And I do not

Re: [KDE/Mac] Multiplatform frameworks

Hi Jeremy, My apologies for going back to basics. Some things you said earlier made me think we are not on the same page, but I now see that we are. On 02/03/2015, at 3:15 AM, Jeremy Whiting wrote: > > The example code you've given does already use prefixes. I'll explain below. > > On Sat, Feb

Re: Review Request 121390: make Qt5 theme build on Linux again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121390/ --- (Updated March 1, 2015, 10:02 p.m.) Status -- This change has been d

Re: Review Request 121390: make Qt5 theme build on Linux again

> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: > > this is wrong - please have a look at various frameworks on how to do it > > properly. In the end it should be: > > #if HAVE_X11 > > // x11 specific stuff > > #endif > > > > obviously it also needs a runtime check: > > if (QX11Info::isPlat

Re: Review Request 121390: make Qt5 theme build on Linux again

> On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: > > this is wrong - please have a look at various frameworks on how to do it > > properly. In the end it should be: > > #if HAVE_X11 > > // x11 specific stuff > > #endif > > > > obviously it also needs a runtime check: > > if (QX11Info::isPlatf

Re: Review Request 121390: make Qt5 theme build on Linux again

> On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: > > this is wrong - please have a look at various frameworks on how to do it > > properly. In the end it should be: > > #if HAVE_X11 > > // x11 specific stuff > > #endif > > > > obviously it also needs a runtime check: > > if (QX11Info::isPlatf

Re: Review Request 121390: make Qt5 theme build on Linux again

> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: > > this is wrong - please have a look at various frameworks on how to do it > > properly. In the end it should be: > > #if HAVE_X11 > > // x11 specific stuff > > #endif > > > > obviously it also needs a runtime check: > > if (QX11Info::isPlat

Re: Review Request 121390: make Qt5 theme build on Linux again

> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: > > this is wrong - please have a look at various frameworks on how to do it > > properly. In the end it should be: > > #if HAVE_X11 > > // x11 specific stuff > > #endif > > > > obviously it also needs a runtime check: > > if (QX11Info::isPlat

Re: Review Request 121390: make Qt5 theme build on Linux again

> On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: > > this is wrong - please have a look at various frameworks on how to do it > > properly. In the end it should be: > > #if HAVE_X11 > > // x11 specific stuff > > #endif > > > > obviously it also needs a runtime check: > > if (QX11Info::isPlatf

Re: [KDE/Mac] Multiplatform frameworks

Ian, The example code you've given does already use prefixes. I'll explain below. On Sat, Feb 28, 2015 at 7:56 PM, Ian Wadham wrote: > Hi Jeremy, > > On 28/02/2015, at 11:20 PM, Jeremy Whiting wrote: > > On Sat, Feb 28, 2015 at 4:51 AM, René J.V. wrote: > > On Saturday February 28 2015 22:00:0

Re: Multiplatform frameworks

On Friday 27 February 2015 22:55:18 Alex Merry wrote: > On Friday 27 February 2015 13:29:59 Jeremy Whiting wrote: > > On Fri, Feb 27, 2015 at 4:05 AM, Alex Merry wrote: > > > 4. Use the PATH_VARS to ecm_configure_package_config_file(). > > > > > > ecm_configure_package_config_file() behaves like

Re: [KDE/Mac] Multiplatform frameworks

On February 28, 2015 1:20:27 PM CET, Jeremy Whiting wrote: >Then data will all be under ~/Library/Application Support/Qt5/appname ? I think Ian's idea was not to use the appname bit (for stuff shared with other apps). >that's a bit cleaner, but why would Qt/KDE applications need to use a >n

Re: [KDE/Mac] Multiplatform frameworks

On Saturday February 28 2015 22:00:07 Ian Wadham wrote: Hi Ian, > Esprit d'escalier. We could change GenericDataDir in QStandardPaths to be: > > "~/Library/Application Support/Qt5", "/Library/Application Support/Qt5" > > That would work for ALL applications that use Qt5 and QSP, regardles

Re: [KDE/Mac] Multiplatform frameworks

On Saturday February 28 2015 18:12:40 Ian Wadham wrote: >One problem is that these are NOT exactly like "~/.local/share", >"/usr/local/share", >"~/.local/share/" and "/usr/local/share/" on Linux. ... >A bundle identifier is something like "org.kde.". Actually, on my >system I find: > >Tara: