Moving KDiagram to extragear/graphics/libs (was: Re: KDiagram libs (KChart, KGantt) in KDE Review)

Hi, 2 weeks have passed, seems there are no stoppers for KDiagram to move on into extragear/graphics/libs :) So filing now a ticket to sysadmin to do the move. Thanks Albert, Aleix, Adriaan for having given KDiagram a check and (helping on) solving the issues you found (so KDiagram is Triple A

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: > > My opinion is that this is a feature which should not be exposed in > > libksysguard. It actually ties libksysguard to KWin, while libksysguard was > > in the past also used in e.g. kdevelop. > > > > If libksysguard wants to offer the f

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: > > My opinion is that this is a feature which should not be exposed in > > libksysguard. It actually ties libksysguard to KWin, while libksysguard was > > in the past also used in e.g. kdevelop. > > > > If libksysguard wants to offer the fu

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On Feb. 21, 2015, 4:08 p.m., Thomas Lübking wrote: > > processui/ksysguardprocesslist.cpp, line 367 > > > > > > leaving aside that the patch is not "clean" (still contains > > kglobalaccel stuff, ie. is probab

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

On Saturday, February 21, 2015 17:19:02 Alexander Richardson wrote: > 2015-02-21 14:43 GMT+00:00 Marco Martin : > > On Sat, Feb 21, 2015 at 1:34 PM, Alexander Richardson > > > > wrote: > >> and then we could also have something like > >> KServiceTypeTrader::findPlugin(serviceType, name) that expa

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

2015-02-21 14:43 GMT+00:00 Marco Martin : > On Sat, Feb 21, 2015 at 1:34 PM, Alexander Richardson > wrote: >> and then we could also have something like >> KServiceTypeTrader::findPlugin(serviceType, name) that expands to >> KServiceTypeTrader::self()->query(serviceType, [](const KPluginInfo &inf

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

2015-02-21 10:02 GMT+00:00 Marco Martin : > Hi all, > As you may have noticed, right now starting plasma is a big spam of > the following error: > Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, > use KPluginInfo::pluginName() in "/whatever/plugin.so" instead. > > i tried to s

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review76389 --- processui/ksysguardprocesslist.cpp

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: > > My opinion is that this is a feature which should not be exposed in > > libksysguard. It actually ties libksysguard to KWin, while libksysguard was > > in the past also used in e.g. kdevelop. > > > > If libksysguard wants to offer the f

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

On Sat, Feb 21, 2015 at 3:43 PM, Marco Martin wrote: > On Sat, Feb 21, 2015 at 1:34 PM, Alexander Richardson > wrote: >> and then we could also have something like >> KServiceTypeTrader::findPlugin(serviceType, name) that expands to >> KServiceTypeTrader::self()->query(serviceType, [](const KPlu

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

On Sat, Feb 21, 2015 at 1:34 PM, Alexander Richardson wrote: > and then we could also have something like > KServiceTypeTrader::findPlugin(serviceType, name) that expands to > KServiceTypeTrader::self()->query(serviceType, [](const KPluginInfo &info) { > return info.pluginName() == name; > } > >

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

> On Feb. 21, 2015, 2:46 a.m., Hrvoje Senjan wrote: > > can you check what needs to be adjusted in plasma-workspace? it fails to > > build with your change: > > > > > > > > [ 451s] > > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: > > error: 'pr

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

> On Feb. 21, 2015, 8:16 a.m., Hrvoje Senjan wrote: > > can you check what needs to be adjusted in plasma-workspace? it fails to > > build with your change: > > > > > > > > [ 451s] > > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: > > error: 'pr

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

> On Feb. 21, 2015, 2:46 a.m., Hrvoje Senjan wrote: > > can you check what needs to be adjusted in plasma-workspace? it fails to > > build with your change: > > > > > > > > [ 451s] > > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: > > error: 'pr

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

> On Feb. 21, 2015, 2:46 a.m., Hrvoje Senjan wrote: > > can you check what needs to be adjusted in plasma-workspace? it fails to > > build with your change: > > > > > > > > [ 451s] > > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: > > error: 'pr

Re: Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

On Saturday, February 21, 2015 11:02:48 Marco Martin wrote: > As you may have noticed, right now starting plasma is a big spam of > the following error: > Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, > use KPluginInfo::pluginName() in "/whatever/plugin.so" instead. > > i t

Warning: KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated

Hi all, As you may have noticed, right now starting plasma is a big spam of the following error: Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use KPluginInfo::pluginName() in "/whatever/plugin.so" instead. i tried to see where it happens, and seems it's in ktradeparsetree.

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Feb. 20, 2015, 11:35 p.m.) Review request for KDE Base Apps, Mar

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review76358 --- can you check what needs to be adjusted in plasma-workspace? i

Re: Review request: QBluez

> Still failing here Oops, sorry. It's because the problem is not that you are running Bluez 4, but because the method call is rejected (auth issue?). Anyway, I modified the tests again so that it now checks whether the Bluez 5 is running and is functional (it checks if the call to GetManagedObje

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Feb. 20, 2015, 9:46 p.m.) Status -- This change has been ma

Review Request 122653: Set permissions for links in remote:, necessary for correct visualization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122653/ --- Review request for kdelibs. Bugs: 339193 http://bugs.kde.org/show_bug

Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/ --- Review request for kdelibs. Bugs: 339193 http://bugs.kde.org/show_bug

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

> On Feb. 17, 2015, 10:22 p.m., David Edmundson wrote: > > Thx for looking into it. Since it is quite a large change I'll keep my intermediate commits and push them now. - Gregor --- This is an automatically generated e-mail. To reply,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

> On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: > > My opinion is that this is a feature which should not be exposed in > > libksysguard. It actually ties libksysguard to KWin, while libksysguard was > > in the past also used in e.g. kdevelop. > > > > If libksysguard wants to offer the fu

Re: plasma-mediacenter in kdereview from extragear

Hello, On Fri, Feb 20, 2015 at 5:06 PM, Jonathan Riddell wrote: > - mockcpp pointer to obscure repository cmake message > - qtmultimedia needs a "this is needed at runtime" cmake message Fixed in http://commits.kde.org/plasma-mediacenter/b17c88d0a7cc6499294e872f5217012e21ba3ac9 > - music and v