Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-02-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Feb. 15, 2015, 4:35 p.m.) Review request for KDE Base Apps, Domi

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-02-15 Thread Gregor Mi
> On Jan. 21, 2015, 10:10 a.m., Dominik Haumann wrote: > > processcore/processes_linux_p.cpp, line 171 > > > > > > Don't you change behavior here? > > > > Before, we just wrote into the varialbes. > >

Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

2015-02-15 Thread Frank Schütte
> On Dez. 8, 2014, 2:15 nachm., Sebastian Kügler wrote: > > solid-device-automounter/kcm/DeviceAutomounterKCM.ui, line 45 > > > > > > Well, with this change, the whatsthis and I suppose the function of > > this c

Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

2015-02-15 Thread Frank Schütte
> On Dez. 8, 2014, 2:15 nachm., Sebastian Kügler wrote: > > The patch just fixes two occurrences of confusion, but leaves others. (See > > inline for one example.) > > > > It should probably be an approach that fixes the confusion once and for > > all. With the naming wrong in the code, bugs a

Review Request 122573: kio-5.7.0 is required

2015-02-15 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122573/ --- Review request for KDE Base Apps. Repository: kde-baseapps Description