Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 9, 2015, 7:11 a.m.) Status -- This change has been mar

Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75657 --- Seems good. Did you changed commit message as David told you ?

Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 9, 2015, 6:03 a.m.) Review request for kde-workspace and Da

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75655 --- dolphin/src/main.cpp

Re: KDiagram libs (KChart, KGantt) in KDE Review

On Mon, Feb 9, 2015 at 1:50 AM, Friedrich W. H. Kossebau wrote: > Am Montag, 9. Februar 2015, 00:23:58 schrieb Albert Astals Cid: >> El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau >> va >> escriure: >> > Hi, >> > >> > Calligra, Massif-Visualizer, KMyMoney (and perhaps m

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 8, 2015, 2:01 p.m., Emmanuel Pescosta wrote: > > dolphin/src/main.cpp, line 109 > > > > > > The validation isn't needed anymore, because QUrl::fromUserInput always > > returns a valid url. (see QUrl do

Re: KDiagram libs (KChart, KGantt) in KDE Review

Am Montag, 9. Februar 2015, 00:23:58 schrieb Albert Astals Cid: > El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau > va > escriure: > > Hi, > > > > Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of > > KDAB's > > nice offer of their KDChart in the GPLv2

Re: KDiagram libs (KChart, KGantt) in KDE Review

El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: > Hi, > > Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's > nice offer of their KDChart in the GPLv2 licensing variant. But as there are > no real public releases of KDChart, all th

KF5 Porting question regarding KFileDialog

I'm porting kolourpaint to KF5 and see that KFileDialog is marked deprecated and QFileDialog should be used instead. However QFileDialog does not have the same functionalities as KFileDialog, e.g. the possibility to show a preview widget or to add another widget to select save options (e.g. Jpeg Qu

Re: Moving KDE Telepathy to kdenetwork

On Sat, Feb 7, 2015 at 5:04 PM, Albert Astals Cid wrote: > > Speaking of releases, you guys understand you'll be in a bigger release > schedule and will have to follow its rules, right? > Yes, obviously. Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75619 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2015, 11

Re: Review Request 122471: Enable Compilation of about Protocol

> On Feb. 8, 2015, 9:19 a.m., Laurent Montel wrote: > > about/kio_about.cpp, line 59 > > > > > > QApplication app(argc, argv); > > app.setApplicationName(QLatin1String("kio_about")); > > > > => you

Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75586 --- What Laurent said, plus a bug in the commit log: you ported aw

Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75584 --- about/kio_about.cpp

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75583 --- Ship it! Thanks for the patch! :) dolphin/src/main.cpp