Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review74716 --- What about gregormi: org.kde.kwin will likely go away in the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 25, 2015, 6:21 p.m.) Review request for KDE Base Apps, Mart

Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122252/ --- Review request for kdelibs and Christian Mollekopf. Repository: kdelibs

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-25 Thread Gregor Mi
> On Jan. 25, 2015, 5:28 p.m., Alex Richardson wrote: > > processui/scripting.h, line 74 > > > > > > Isn't just changing the PROPERTY macro enough? > > Or is it used in some other file? I did the refactoring

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 25, 2015, 5:33 p.m.) Review request for KDE Base Apps, Mart

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 25, 2015, 5:47 p.m.) Review request for KDE Base Apps, Mart

Re: Sysadmin report on the modernization of our infrastructure

2015-01-25 Thread Ben Cooksley
On Sun, Jan 25, 2015 at 12:23 PM, Matthew Dawson wrote: > On January 21, 2015 05:12:07 PM Ben Cooksley wrote: >> Hi all, >> >> As promised in the earlier thread, i'd like to present the sysadmin >> report on the state of the infrastructure surrounding our code. >> >> It contains a detailed summary

Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- Review request for KDE Base Apps and John Tapsell. Repository: libksysgua

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-25 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review74713 --- Other than these two issues looks good to me, but someone else

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 25, 2015, 12:01 p.m.) Review request for KDE Base Apps, Dom

Re: Sysadmin report on the modernization of our infrastructure

2015-01-25 Thread Matthew Dawson
On January 21, 2015 05:12:07 PM Ben Cooksley wrote: > Hi all, > > As promised in the earlier thread, i'd like to present the sysadmin > report on the state of the infrastructure surrounding our code. > > It contains a detailed summary of what is broken with our existing > systems, why change is n

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 25, 2015, 12:46 a.m.) Review request for KDE Base Apps, Dom