Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Ben Cooksley
On Sat, Jan 24, 2015 at 4:05 AM, Thomas Lübking wrote: > On Freitag, 23. Januar 2015 03:34:11 CET, Ben Cooksley wrote: > >> For that particular post - we would need to install Arcanist on all of >> the build nodes behind build.kde.org. >> The libphutil part you see there goes on the Phabricator in

Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/17/ --- Review request for kdelibs and Christian Mollekopf. Repository: kdelibs

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Thomas Lübking
On Freitag, 23. Januar 2015 03:34:11 CET, Ben Cooksley wrote: For that particular post - we would need to install Arcanist on all of the build nodes behind build.kde.org. The libphutil part you see there goes on the Phabricator instance itself - and is used to inform Jenkins that it needs to per

Re: Feature matrix for future infrastructure

2015-01-23 Thread Boudewijn Rempt
On Thu, 22 Jan 2015, Milian Wolff wrote: Hey all, I started this page just now: https://community.kde.org/Sysadmin/FutureInfrastructure It's pretty limited, so far. I hope everyone could help out and extend it and fill it with the information and verify that each contestant is displayed in a

Re: Feature matrix for future infrastructure

2015-01-23 Thread Boudewijn Rempt
Hm... That matrix needs a heck of a lot of work before it's worth its while. It basically perpetuates the illusion that phabricator and gerrit are the same thing, which isn't correct. Gerrit is basically a reviewboard with a git integration, phabricator is a whole integrated development platfo

Re: Feature matrix for future infrastructure

2015-01-23 Thread Martin Klapetek
On Thu, Jan 22, 2015 at 2:20 PM, Milian Wolff wrote: > Hey all, > > I started this page just now: > > https://community.kde.org/Sysadmin/FutureInfrastructure > > It's pretty limited, so far. I hope everyone could help out and extend it > and > fill it with the information and verify that each con

Re: kio-extras

2015-01-23 Thread Harald Sitter
On Thu, Jan 22, 2015 at 11:42 AM, Jonathan Riddell wrote: > kio-extras is currently released part of Plasma 5. It's need said > that it would be better to be part of applications because they're > plugins used by applications and typically not by the desktop. They are plugins used by kio... any

Re: kio-extras

2015-01-23 Thread Bhushan Shah
On Thu, Jan 22, 2015 at 4:12 PM, Jonathan Riddell wrote: > kio-extras is currently released part of Plasma 5. It's need said > that it would be better to be part of applications because they're > plugins used by applications and typically not by the desktop. With > Plasma 5.2 about to go out sha

Re: Review Request 122212: [baseapps] Make tests optional

2015-01-23 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122212/#review74587 --- Ship it! Ship It! - Emmanuel Pescosta On Jan. 22, 2015, 10

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Ben Cooksley
On Fri, Jan 23, 2015 at 1:27 AM, Milian Wolff wrote: > On Thursday 22 January 2015 08:25:08 Ben Cooksley wrote: > > Hey, thanks for the clarification. I'll remove everything which I think was > sufficiently answered by you. No problem. > > > >> > Furthermore, some open questions from my side, r

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Ben Cooksley
On Fri, Jan 23, 2015 at 4:10 PM, Milian Wolff wrote: > On Friday 23 January 2015 15:40:40 Ben Cooksley wrote: >> On Fri, Jan 23, 2015 at 3:52 AM, Milian Wolff wrote: >> > On Wednesday 21 January 2015 17:12:07 Ben Cooksley wrote: >> >> Hi all, >> >> >> >> As promised in the earlier thread, i'd lik

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
On Friday 23 January 2015 15:40:40 Ben Cooksley wrote: > On Fri, Jan 23, 2015 at 3:52 AM, Milian Wolff wrote: > > On Wednesday 21 January 2015 17:12:07 Ben Cooksley wrote: > >> Hi all, > >> > >> As promised in the earlier thread, i'd like to present the sysadmin > >> report on the state of the in

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Ben Cooksley
On Fri, Jan 23, 2015 at 9:04 AM, Dominik Haumann wrote: > On Wednesday 21 January 2015 22:20:18 Eike Hein wrote: >> >> On 01/21/2015 05:12 AM, Ben Cooksley wrote: >> > Hi all, >> > >> > As promised in the earlier thread, i'd like to present the sysadmin >> > report on the state of the infrastructu

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Ben Cooksley
On Fri, Jan 23, 2015 at 3:52 AM, Milian Wolff wrote: > On Wednesday 21 January 2015 17:12:07 Ben Cooksley wrote: >> Hi all, >> >> As promised in the earlier thread, i'd like to present the sysadmin >> report on the state of the infrastructure surrounding our code. >> >> It contains a detailed summ

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Dominik Haumann
On Wednesday 21 January 2015 22:20:18 Eike Hein wrote: > > On 01/21/2015 05:12 AM, Ben Cooksley wrote: > > Hi all, > > > > As promised in the earlier thread, i'd like to present the sysadmin > > report on the state of the infrastructure surrounding our code. > > As someone on the original git inf

Feature matrix for future infrastructure

2015-01-23 Thread Milian Wolff
Hey all, I started this page just now: https://community.kde.org/Sysadmin/FutureInfrastructure It's pretty limited, so far. I hope everyone could help out and extend it and fill it with the information and verify that each contestant is displayed in a fair light. Please add links, comments etc

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Marco Martin
On Wednesday 21 January 2015 17:12:07 Ben Cooksley wrote: > Hi all, > > As promised in the earlier thread, i'd like to present the sysadmin > report on the state of the infrastructure surrounding our code. > > It contains a detailed summary of what is broken with our existing > systems, why chang

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
On Wednesday 21 January 2015 17:12:07 Ben Cooksley wrote: > Hi all, > > As promised in the earlier thread, i'd like to present the sysadmin > report on the state of the infrastructure surrounding our code. > > It contains a detailed summary of what is broken with our existing > systems, why chang

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
On Thursday 22 January 2015 08:25:08 Ben Cooksley wrote: Hey, thanks for the clarification. I'll remove everything which I think was sufficiently answered by you. > > Furthermore, some open questions from my side, regarding Phabricator: > > > > - is it really trivial to implement commit hooks

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/#review74552 --- Ship it! Looks good to me, let's get this in, I'll try to fin

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/ --- (Updated Jan. 22, 2015, 5:35 p.m.) Status -- This change has been ma

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread David Faure
> On Jan. 22, 2015, 7:47 a.m., David Faure wrote: > > kdeui/tests/krecursivefilterproxymodeltest.cpp, line 126 > > > > > > Shouldn't rowsInserted even be emitted 3 times? Once for row1, once for > > child, once

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread David Faure
> On Jan. 22, 2015, 7:47 a.m., David Faure wrote: > > kdeui/itemviews/krecursivefilterproxymodel.cpp, line 149 > > > > > > refreshAll isn't used anymore, the new code always "refreshes all > > ascendants" > > C

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/ --- (Updated Jan. 22, 2015, 4:06 p.m.) Review request for kdelibs and Stephen

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/ --- (Updated Jan. 22, 2015, 3:11 p.m.) Review request for kdelibs and Stephen

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread Christian Mollekopf
> On Jan. 22, 2015, 7:47 a.m., David Faure wrote: > > kdeui/itemviews/krecursivefilterproxymodel.cpp, line 149 > > > > > > refreshAll isn't used anymore, the new code always "refreshes all > > ascendants" The d

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread Christian Mollekopf
> On Jan. 22, 2015, 7:47 a.m., David Faure wrote: > > The commit log has the same tree twice. Was "D" supposed to be omitted from > > the second tree? > > > > Overall I'm extremely surprised that this class didn't have a unittest yet. > > I recently wrote many proxymodels for a customer, with f

kio-extras

2015-01-23 Thread Jonathan Riddell
kio-extras is currently released part of Plasma 5. It's need said that it would be better to be part of applications because they're plugins used by applications and typically not by the desktop. With Plasma 5.2 about to go out shall I ask for kio-extras to be moved and if so into which module?

Review Request 122212: [baseapps] Make tests optional

2015-01-23 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122212/ --- Review request for KDE Base Apps. Repository: kde-baseapps Description