Re: Adding experimental parts to a KF5 library

2015-01-15 Thread Kevin Kofler
Ivan Čukić wrote: > I do agree that is would be a proper way to handle it. The only > problem I see with it is that the point is actually not to provide > binary compatibility, nor proper handling of BIC. > > At least in the case I have. Namely, the point is for the library to > be used *only* for

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review74100 --- see also last comments in https://git.reviewboard.kde.org/r/12

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review74096 --- processcore/process.h

Re: SFLPhone-KDE is now Ring-KDE and is moving to kdereview

2015-01-15 Thread Elv1313 .
Hello Albert, Thanks for your comments. > * src/abstractitembackend.h is twice in libringclient_LIB_HDRS I will fix that, thanks, maybe we should add a Krazy2 check for that. I know Laurent Model has posted one on planetkde.org for the code a while back, I haven’t used it yet. > * You have some