Re: Adding experimental parts to a KF5 library

2015-01-12 Thread Kevin Kofler
Ivan Čukić wrote: > - 0 soversion to show that the library has no stable ABI. I'd actually set both the soname and the fully-versioned name to libfoo.so.0.1, then if you change something binary-incompatibly, libfoo.so.0.2, etc. (or use libfoo.so.0.1 etc. as the soname and something like libfoo.

Re: Review Request 121717: libksysguard/processtable: Add new column "Relative Start Time"

2015-01-12 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/#review73892 --- Ship it! To me, this patch looks good. Given Albert also did

Add your blog to the Qt planet

2015-01-12 Thread Àlex Fiestas
Hey! In the Randa sprint we discussed about how to promote all the awesome stuff we do better in the Qt community. One of the ideas we came up with was to add the blogs of our developers to the Qt planet. The process is like ours, so just clone the Qt repository www/planetqt and submit a code

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-12 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 12, 2015, 2:30 p.m.) Review request for KDE Base Apps and J

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-12 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 12, 2015, 2:24 p.m.) Review request for KDE Base Apps and J

Re: Review Request 121717: libksysguard/processtable: Add new column "Relative Start Time"

2015-01-12 Thread Gregor Mi
> On Jan. 10, 2015, 10:18 p.m., Albert Astals Cid wrote: > > processcore/process.cpp, line 203 > > > > > > initialize to 0 in the constructor? Yes, I forgot that, thanks. - Gregor ---

Re: Review Request 121717: libksysguard/processtable: Add new column "Relative Start Time"

2015-01-12 Thread Gregor Mi
> On Jan. 10, 2015, 4:29 p.m., Dominik Haumann wrote: > > processui/ProcessModel.cpp, line 1655 > > > > > > What do you mean by the comment 'first iteration'? I removed it because it was not needed - Gregor

Re: Review Request 121717: libksysguard/processtable: Add new column "Relative Start Time"

2015-01-12 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/ --- (Updated Jan. 12, 2015, 2:07 p.m.) Review request for KDE Base Apps and J