Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Ian Wadham
> On Jan. 8, 2015, 6:12 p.m., Milian Wolff wrote: > > personally, I also think that if you tested and it works, and Allan has no > > objections, that you can go ahead and push this. but please don't comment > > out code, just remove it. > > René J.V. Bertin wrote: > OK, will do. > >

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2015-01-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review73542 --- Ship it! Sorry, this one got drowned in the ML noise and I mi

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2015-01-08 Thread David Faure
> On Oct. 19, 2014, 8:25 a.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 870 > > > > > > Should be const QString &mountPoint, you're not modifying it. > > > > Also, rename this method to

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Luigi Toscano
David Edmundson ha scritto: > > > On Thu, Jan 8, 2015 at 5:54 PM, Luigi Toscano > wrote: > > Jonathan Riddell ha scritto: > > On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote: > >>Regarding ModemManagerQt, libbluedevil, libkscreen a

KDE Frameworks 5.6.0 released

2015-01-08 Thread David Faure
08th January 2015. KDE today announces the release of KDE Frameworks 5.6.0. KDE Frameworks are 60 addon libraries to Qt which provide a wide variety of commonly needed functionality in mature, peer reviewed and well tested libraries with friendly licensing terms. For an introduction see the Fra

Jenkins build is back to stable : kde-runtime_stable #638

2015-01-08 Thread KDE CI System
See

Jenkins build became unstable: kde-runtime_stable #637

2015-01-08 Thread KDE CI System
See

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Mario Fux
Am Donnerstag, 08. Januar 2015, 22.05:45 schrieb David Edmundson: Morning [snip] > > That said, there is no consensus here, as it seems I'm expressing I'm > > part of > > a minority view and I'm not in the release team, if no one else says > > anything > > else I would stop here for this specifi

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread David Edmundson
On Thu, Jan 8, 2015 at 5:54 PM, Luigi Toscano wrote: > Jonathan Riddell ha scritto: > > On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote: > >>Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they > are > >>supposed to be frameworks stuff (not sure about baloo) b

Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros

2015-01-08 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121935/ --- Review request for kdelibs. Repository: kactivities Description ---

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread René J . V . Bertin
> On Jan. 8, 2015, 7:12 p.m., Milian Wolff wrote: > > personally, I also think that if you tested and it works, and Allan has no > > objections, that you can go ahead and push this. but please don't comment > > out code, just remove it. OK, will do. I'll give it a bit more testing, though. Mu

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/#review73521 --- Ship it! personally, I also think that if you tested and it w

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/#review73519 --- No, I can't recall why i did that. You know a lot more about

Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- Review request for KDE Software on Mac OS X, kdelibs and Allen Winter. Re

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Luigi Toscano
Jonathan Riddell ha scritto: > On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote: >>Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they are >>supposed to be frameworks stuff (not sure about baloo) but they are not >>ready yet. Why not created a frameworks-nex

Re: Fwd: Plasma 5.2 bits for kdereview

2015-01-08 Thread Luigi Toscano
Sebastian Kügler ha scritto: > On Wednesday, January 07, 2015 20:31:57 Albert Astals Cid wrote: >>> Albert has said he's fine with KDE Applications depending on Plasma (I >>> think) >>> http://mail.kde.org/pipermail/kde-frameworks-devel/2015-January/021332.htm >>> l >> >> I said "I'm fine with KDE

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Jonathan Riddell
On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote: >Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they are >supposed to be frameworks stuff (not sure about baloo) but they are not >ready yet. Why not created a frameworks-next group to include them there >

Re: Fwd: Plasma 5.2 bits for kdereview

2015-01-08 Thread Lamarque Souza
ModemManagerQt is used by two KDE Applications, Plasma NM and KDE Telepathy. The former uses it to retrieve information about mobile broadband connections (operator and signal quality), unlocking modem's sim card when activating 3G connections, listing available modems in mobile connection wizard w

Re: Fwd: Plasma 5.2 bits for kdereview

2015-01-08 Thread Sebastian Kügler
On Wednesday, January 07, 2015 20:31:57 Albert Astals Cid wrote: > > Albert has said he's fine with KDE Applications depending on Plasma (I > > think) > > http://mail.kde.org/pipermail/kde-frameworks-devel/2015-January/021332.htm > > l > > I said "I'm fine with KDE Applications depending on Plasma

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Kåre Särs
On Thursday 08 January 2015 21:52:48 Ian Wadham wrote: > On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: > > On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham wrote: > > - I don't think Windows has anything like Baloo or KWallet, but Apple > > > > OS X certainly has, and has had for years. We,

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Ian Wadham
On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: > On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham wrote: > - I don't think Windows has anything like Baloo or KWallet, but Apple > OS X certainly has, and has had for years. We, on the KDE-Mac list, > are starting to integrate KWallet and Ap

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Vishesh Handa
On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham wrote: > - I don't think Windows has anything like Baloo or KWallet, but Apple > OS X certainly has, and has had for years. We, on the KDE-Mac list, > are starting to integrate KWallet and Apple's Keychain app, but Baloo > is still an

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Lamarque Souza
Hi all, Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they are supposed to be frameworks stuff (not sure about baloo) but they are not ready yet. Why not created a frameworks-next group to include them there until they are ready to move to frameworks (being it KF5 or even KF6 in th