Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Aaron J. Seigo
On Wednesday, December 10, 2014 15.27:31 Ben Cooksley wrote: > It has come to my attention that some developers have "issues" with > KDE infrastructure in certain areas. This is the first time i've heard I suspect the issues are the same ones that led us to experiment with gitlab a while back. Ch

Re: New framework to review: KPackage

2014-12-10 Thread Kevin Kofler
Marco Martin wrote: > In the past weeks I have been working on a new framework, called KPackage. You ARE aware that KPackage was the name of an old frontend for RPM and other package managers that used to be part of the KDE Software Compilation 4? Kevin Kofler

Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation

2014-12-10 Thread Kevin Kofler
Martin Klapetek wrote: > I was acutally thinking about the same, would mean the headers are > duplicated though. Additionally the old headers could have some #pragma > message so it tells people while building. And you also have to check whether the file system you're installing to is case-sensit

Re: Facebook Flint vis-à-vis Krazy

2014-12-10 Thread viv...@gmail.com
Il 02/12/2014 21:40, Allen Winter ha scritto: > Howdy, > > Today I was informed that Facebook has a tool similar in concept to Krazy, > called Flint [1] > > You might want to read [1] and let me know if there are any checkers listed > there that > you'd like to see added to Krazy. Krazy already

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Jan Kundrát
On Thursday, 11 December 2014 00:51:28 CEST, Albert Astals Cid wrote: Yes, it is harder. Yyou need to setup git correctly, so that "gerrit" in that command is valid, you need to understand you're pushing to a different server than the "real" one, you need to commit (i never do format-patch, j

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Albert Astals Cid
El Dijous, 11 de desembre de 2014, a les 00:41:56, Jan Kundrát va escriure: > On Wednesday, 10 December 2014 19:41:31 CEST, Albert Astals Cid wrote: > > D is really important to me since it makes it harder to contribute to non > > hardcore git users; it took me days to start understanding Qt's > >

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Jan Kundrát
On Wednesday, 10 December 2014 19:41:31 CEST, Albert Astals Cid wrote: D is really important to me since it makes it harder to contribute to non hardcore git users; it took me days to start understanding Qt's gerrit and i am still not sure i understand it fully, with reviewboard i do git diff a

Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation

2014-12-10 Thread Martin Klapetek
On Thu, Dec 11, 2014 at 12:09 AM, Albert Astals Cid wrote: > > Can we get both "the correct" and the old way and mark it as deprecated? > > "the correct" way is cool since it helps us by having the same way of using > stuff on all frameworks, predictibility is awesome. > And it eases up porting

Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation

2014-12-10 Thread Albert Astals Cid
El Dimecres, 10 de desembre de 2014, a les 10:17:23, Martin Klapetek va escriure: > On Wed, Dec 10, 2014 at 9:56 AM, Raymond Wooninck > > wrote: > > On Tuesday 9 December 2014 16:16:23 Martin Klapetek wrote: > > > Git commit 0256b80e9ac7c1459afe0ac021d27e985cba14d3 by Martin Klapetek. > > > Comm

Re: Review Request for KDecoration

2014-12-10 Thread Albert Astals Cid
El Dimecres, 10 de desembre de 2014, a les 15:44:02, Thomas Lübking va escriure: > On Mittwoch, 10. Dezember 2014 13:11:07 CEST, Christoph Feck wrote: > > Every interactive on-screen element must have a text, either as a > > label, or as a tooltip. This is a simple accessibility requirement. > >

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Luigi Toscano
Albert Astals Cid ha scritto: > > I see some problems with gerrit: > [...] > > D) There's no way to create a review without using relatively unfriendly > gerrit process > > [...] > > D is really important to me since it makes it harder to contribute to non > hardcore git users; it took me da

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Albert Astals Cid
El Dimecres, 10 de desembre de 2014, a les 16:53:09, Jan Kundrát va escriure: > On Wednesday, 10 December 2014 10:28:59 CEST, Christian Mollekopf wrote: > > * pull requests/the webinterface: reviewboard is awesome for single > > patches > > every now and then, it's rather useless when you work with

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Jan Kundrát
On Wednesday, 10 December 2014 10:28:59 CEST, Christian Mollekopf wrote: * pull requests/the webinterface: reviewboard is awesome for single patches every now and then, it's rather useless when you work with branches IMO. With github we have a nice webinterface to review branches while keeping

Re: Review Request for KDecoration

2014-12-10 Thread Thomas Lübking
On Mittwoch, 10. Dezember 2014 13:11:07 CEST, Christoph Feck wrote: Every interactive on-screen element must have a text, either as a label, or as a tooltip. This is a simple accessibility requirement. Does this imply a formal representation (eg. to be accessed as object property from some sc

Re: New framework to review: KPackage

2014-12-10 Thread David Edmundson
​The binary is called kpackagetool. Given the complications we've had with frameworks co-installability does it make sense to call it kpackagetool5? The class name in kpackagetool/kpackagetool.cpp should probably be renamed Documentation at the top of PackageLoader should avoid saying Plasma quit

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Sebastian Kügler
[I love our infrastructure, just this bit triggered my reply-to-email reflex] On Wednesday, December 10, 2014 10:28:59 Christian Mollekopf wrote: > * deleting branches: This is the only major gripe I have with the kde > infrastructure. I think everyone should be able to delete branches (except >

Re: Review Request for KDecoration

2014-12-10 Thread Christoph Feck
On Wednesday 10 December 2014 08:07:25 Martin Gräßlin wrote: > My personal opinion is that it doesn't need the tooltips. If one > cannot recognize the buttons than the design language of the > decoration is really bad. Every interactive on-screen element must have a text, either as a label, or as

Re: New framework to review: KPackage

2014-12-10 Thread Marco Martin
On Wednesday 10 December 2014, Albert Astals Cid wrote: > > I would like to submit it (kpackage repo) for the usual 2 weeks period of > > review. > > Add const & > void setDefaultMimeTypes(QStringList mimeTypes); > void setMimeTypes(const char *key, QStringList mimeTypes); > > You probabl

Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation

2014-12-10 Thread Martin Klapetek
On Wed, Dec 10, 2014 at 9:56 AM, Raymond Wooninck wrote: > On Tuesday 9 December 2014 16:16:23 Martin Klapetek wrote: > > Git commit 0256b80e9ac7c1459afe0ac021d27e985cba14d3 by Martin Klapetek. > > Committed on 09/12/2014 at 16:16. > > Pushed by mklapetek into branch 'master'. > > > > Fix typo in

API Breakage?: Re: [kcmutils] src: Fix typo in headers generation

2014-12-10 Thread Raymond Wooninck
On Tuesday 9 December 2014 16:16:23 Martin Klapetek wrote: > Git commit 0256b80e9ac7c1459afe0ac021d27e985cba14d3 by Martin Klapetek. > Committed on 09/12/2014 at 16:16. > Pushed by mklapetek into branch 'master'. > > Fix typo in headers generation > > Also install to properly capitalized subdirec