Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
> On Ноя. 18, 2014, 7:46 п.п., Lukáš Tinkl wrote: > > Please commit to kdesu framework as well Done. - Andrey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/#review70605

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/ --- (Updated Ноя. 19, 2014, 1:52 д.п.) Status -- This change has been ma

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Kevin Funk
On Wednesday 19 November 2014 00:09:25 Albert Astals Cid wrote: > El Dimarts, 18 de novembre de 2014, a les 23:01:14, Alex Merry va escriure: > > On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: > > > I didn't even know we were using json now. Why did we change from > > > .desktop > >

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Albert Astals Cid
El Dimarts, 18 de novembre de 2014, a les 23:01:14, Alex Merry va escriure: > On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: > > I didn't even know we were using json now. Why did we change from .desktop > > file to .json ones? What's the benefit? Seems like .desktop files did > > th

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Alex Merry
On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: > I didn't even know we were using json now. Why did we change from .desktop > file to .json ones? What's the benefit? Seems like .desktop files did their > job good enough and we have all the tooling available already. Because that's w

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Albert Astals Cid
El Dimarts, 18 de novembre de 2014, a les 23:35:48, Milian Wolff va escriure: > On Tuesday 18 November 2014 22:31:08 Albert Astals Cid wrote: > > El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va > > escriure: > > > On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: > >

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 22:31:08 Albert Astals Cid wrote: > El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va escriure: > > On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: > > > On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: > > > > > > > Or can we now

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Albert Astals Cid
El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va escriure: > On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: > > On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: > > > > > > Or can we nowadays write the .json files directly, i.e. can > > > > > > scripty/ki18

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/#review70605 --- Ship it! Please commit to kdesu framework as well - Lukáš Ti

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 18, 2014, 7:30 p.m.) Status -- This change has been ma

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Thomas Lübking
> On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote: > > attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 > > > > > > is > > > > KdePlatformDependent::~KdePlatformDependent() > > { > >

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/#review70601 --- Ship it! Ship It! - Albert Astals Cid On nov. 17, 2014, 9:

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
> On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote: > > attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 > > > > > > is > > > > KdePlatformDependent::~KdePlatformDependent() > > { > >if

Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121169/ --- Review request for KDE Runtime. Repository: kde-runtime Description ---

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/#review70583 --- thumbnail/CMakeLists.txt

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: > On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: > > > > > Or can we nowadays write the .json files directly, i.e. can > > > > > scripty/ki18n > > > > > cope with them nowadays? > > > > > > > > So, any chance we can use .json

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Thomas Lübking
> On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote: > > attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 > > > > > > is > > > > KdePlatformDependent::~KdePlatformDependent() > > { > >

Re: desktoptojson and list properties

2014-11-18 Thread Sebastian Kügler
On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: > > > > Or can we nowadays write the .json files directly, i.e. can > > > > scripty/ki18n > > > > cope with them nowadays? > > > > > > So, any chance we can use .json directly here? > > > > That should be possible, you can just drop the json

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review70581 --- Ship it! Looks sane to me, also solves a real-world problem.