Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-12 Thread Pedro Francisco
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/#review70280 --- Ship it! Ship It! - Pedro Francisco On Nov. 8, 2014, 10:14

Re: decoration.h | [was: Review Request for KDecoration]

2014-11-12 Thread Thomas Lübking
On Mittwoch, 12. November 2014 08:19:54 CEST, Martin Gräßlin wrote: My thought was that it's going to be * rect for top * rect for left * rect for right * rect for bottom leaving out the center element. Thus a QRegion to render it in one go. My thought was that we'd generate a buffer for each

Re: Re: Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-12 Thread Martin Gräßlin
Martin GräßlinOn Tuesday 11 November 2014 17:53:53 wrote: > On Tuesday 11 November 2014 17:48:58 Thomas Lübking wrote: > > On Dienstag, 11. November 2014 17:06:53 CEST, Martin Gräßlin wrote: > > > In case you have better naming suggestions please let me know. > > > > "::geometry(Qt::WindowFrameSe