Re: Re: decoration.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Tuesday 11 November 2014 23:23:09 Thomas Lübking wrote: > On Dienstag, 11. November 2014 13:30:09 CEST, Martin Gräßlin wrote: > > Added a QRegion parameter (thought is to be able to render the complete > > > decoration in one go if needed): > Why a region? The core sends a rect (needs implicit

Re: decoration.h | [was: Review Request for KDecoration]

2014-11-11 Thread Thomas Lübking
On Dienstag, 11. November 2014 13:30:09 CEST, Martin Gräßlin wrote: Added a QRegion parameter (thought is to be able to render the complete decoration in one go if needed): Why a region? The core sends a rect (needs implicit QRegion construction) and the deco will likely call boundingRect() o

Re: Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Tuesday 11 November 2014 17:48:58 Thomas Lübking wrote: > On Dienstag, 11. November 2014 17:06:53 CEST, Martin Gräßlin wrote: > > In case you have better naming suggestions please let me know. > > "::geometry(Qt::WindowFrameSection tile)" ? > > If you need parameterless accessors, i'd just add

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Thomas Lübking
On Dienstag, 11. November 2014 17:06:53 CEST, Martin Gräßlin wrote: In case you have better naming suggestions please let me know. "::geometry(Qt::WindowFrameSection tile)" ? If you need parameterless accessors, i'd just add a geometry ::topLeftGeometry() Cheers, Thomas

Re: Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Tuesday 11 November 2014 17:00:24 Thomas Lübking wrote: > On Dienstag, 11. November 2014 14:43:56 CEST, Martin Gräßlin wrote: > >> "BorderSize" - do we *really* want to keep this or rather allow > >> pixel/pointwise configuration of 2,3, or 4 border sizes globally? > > > > could you please expl

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: > decorationshadow.h > -- > QSize topLeft() etc. etc.: > a) shadow->topLeft() does not sound like a size > b) the entire information (9 tiles) can also be provided by two rects > (innerRect, outerRect) c) with a conv. func.

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Thomas Lübking
On Dienstag, 11. November 2014 14:43:56 CEST, Martin Gräßlin wrote: "BorderSize" - do we *really* want to keep this or rather allow pixel/pointwise configuration of 2,3, or 4 border sizes globally? could you please explain your alternative approach? I'm kind of not getting it and yes I'm also

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: > decoratedclient.h > -- > > "maximal available" -> "maximal possible" Addressed in 389ff3b > "borderingScreenEdges" -> "adjacentScreenEdges" or "touchedScreenEdges" Renamed to adjacentScreenEdges: * kdecoration: f8d114

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: > decorationdefines.h, decorationsettings.h > - > "BorderSize" - do we *really* want to keep this or rather allow > pixel/pointwise configuration of 2,3, or 4 border sizes globally? could you please

Re: decoration.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 13:31:57 Thomas Lübking wrote: > decoration.h > - > borderLeft|Right|Bottom|Top > Use QMargins here as well (they'll usually be required together)? addressed with: * kdecoration: f4ab8e4 * kdecoration-viewer: 1a1bbad * breeze: db43181 * kwin: 1c90ca9 > >