Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-09 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70152 --- When I originally got KF5 to compile on windows I seem to reme

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70150 --- Ship it! Other than that it should go in. liboxygen/CMakeLi

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70149 --- Shouldn't it be actually implemented then? - Aleix Pol Gonzal

Re: Review Request 121078: Fix exports.

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70148 --- Ship it! Looks good to me, really useful and definitely a ste

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/#review70147 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 10

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70122 --- liboxygen/CMakeLists.txt

Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-09 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: ki

Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-09 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/ --- Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: ki

Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/ --- Review request for kde-workspace and kdewin. Repository: oxygen Descrip