Review Request 121081: QT_WA

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121081/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository:

Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository:

Review Request 121079: Fix building dolphin tests on MSVC

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository:

Review Request 121078: Fix exports.

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository:

Review Request 121077: Check before using -Wno-deprecated-declarations.

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121077/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository:

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/ --- (Updated Nov. 8, 2014, 10:14 p.m.) Review request for KDE Base Apps, KDE

Re: New CHANGELOG: keyword

2014-11-08 Thread Thiago Macieira
On Saturday 08 November 2014 01:52:06 Albert Astals Cid wrote: > El Divendres, 7 de novembre de 2014, a les 16:35:21, Thiago Macieira va > > escriure: > > On Saturday 08 November 2014 00:58:49 Albert Astals Cid wrote: > > > Hi, we've added a new CHANGELOG: keyword to > > > https://techbase.kde.org

Re: Review Request 121021: reverse ShowIconsOnPushButtons default

2014-11-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121021/#review70083 --- Code wise it's fine, same for the other two. It might be a goo