Re: Review Request 120975: Allow user to cancel out of the SSL certificate accept duration dialog

2014-11-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120975/ --- (Updated Nov. 6, 2014, 12:41 a.m.) Status -- This change has been ma

Re: Review Request 120975: Allow user to cancel out of the SSL certificate accept duration dialog

2014-11-05 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120975/#review69919 --- Tested and works as expected. Ship it from my part. - Andrea

Re: Ksshaskpass ?

2014-11-05 Thread David Faure
[cutting down on the massive cross-posting] On Monday 03 November 2014 14:13:50 Jeremy Whiting wrote: > ksshaskpass has no more krazy issues and has been moved to kdereview. > I think it's final resting place should be kde/workspace but I'm open > to other ideas. It is usable on other platforms be

Re: SDDM-KCM In Review

2014-11-05 Thread David Edmundson
On Thu, Oct 9, 2014 at 12:56 AM, Jeremy Whiting wrote: > David, > > I cloned the git repo here, and built it and installed it next to my > other kf5 stuff. (The README still mentions kde4-config, that probably > should be updated btw). > It runs ok here, but doesn't work :) Maybe I need to symlin

Re: SDDM-KCM In Review

2014-11-05 Thread David Edmundson
​I've fixed almost all the review comments, with the exception of unit tests as I can't fake getting the list of users, and if I did fake it that would remove the entire point of what I'm testing. David