Re: Re: Review Request for KDecoration

2014-11-04 Thread Martin Gräßlin
On Tuesday 04 November 2014 13:40:30 Milian Wolff wrote: > > I'd rather stress "notice that the return value can be nullptr and change > > during the lifetime of the DecoratedClient". > > > > The user can still do > > Decoration *m_deco = m_client->decoration(); // fails at some point > > > > Ove

Re: Review Request for KDecoration

2014-11-04 Thread Milian Wolff
On Tuesday 04 November 2014 11:53:55 Thomas Lübking wrote: > On Dienstag, 4. November 2014 10:20:18 CEST, Martin Gräßlin wrote: > >> DecorationSettings > >> onAllDesktopsAvailableChanged > >> -> remove the "on" prefix > > > > No, maybe the name is bad, but if the on is removed the meaning > > chan

Review Request 120975: Allow user to cancel out of the SSL certificate accept duration dialog

2014-11-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120975/ --- Review request for kdelibs. Bugs: 335375 http://bugs.kde.org/show_bug

Re: Review Request for KDecoration

2014-11-04 Thread Thomas Lübking
On Dienstag, 4. November 2014 10:20:18 CEST, Martin Gräßlin wrote: DecorationSettings onAllDesktopsAvailableChanged -> remove the "on" prefix No, maybe the name is bad, but if the on is removed the meaning changes. It's whether one can put DecoratedClients "on all desktops" (at lest two virtu

Re: Re: Review Request for KDecoration

2014-11-04 Thread Martin Gräßlin
On Monday 03 November 2014 23:33:15 Milian Wolff wrote: > On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: > > Hi KDE core developers, > > > > today I want to start the review process for the new KDecoration > > library[1]. This library is intended to replace the window decoration > > libr