Review Request 120900: kio_sftp: Use the right type for timeout_sec and timeout_usec.

2014-10-29 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120900/ --- Review request for KDE Runtime and Andreas Schneider. Bugs: 331674 ht

Re: KConfigDialog

2014-10-29 Thread Jeremy Whiting
The widget is a combobox of languages, where we show the language name, but store the language two leter iso string in config. Maybe it can be done with kconfigxt, dunno. I'll look into it, thanks. Jeremy On Wed, Oct 29, 2014 at 4:00 PM, Albert Astals Cid wrote: > El Dilluns, 27 d'octubre de 20

Re: KConfigDialog

2014-10-29 Thread Albert Astals Cid
El Dilluns, 27 d'octubre de 2014, a les 22:22:12, Jeremy Whiting va escriure: > Hello, > > Is there a way to have custom settings mixed with kcfg_ type settings > in a KConfigDialog? Kanagram does this, but it only works when another > kcfg_ named widget changes too. The combobox to select which l

Re: Gerrit: merging feature branches

2014-10-29 Thread Jan Kundrát
On Tuesday, 28 October 2014 19:13:53 CET, Marco Martin wrote: Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. Hi, Gerrit is quite flexible, and supports many different use cases. It's up to us to agree on h

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Christoph Feck
> On Oct. 29, 2014, 12:02 p.m., Helio Castro wrote: > > Ok, way better than the previous one :-) > > Frank Schütte wrote: > Thanks for your approval. Now who is going to commit my patch? I don't > have write access to the repository, as far as I know. > > Christoph Feck wrote: > me. I

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Frank Schütte
> On Okt. 29, 2014, 12:02 nachm., Helio Castro wrote: > > Ok, way better than the previous one :-) > > Frank Schütte wrote: > Thanks for your approval. Now who is going to commit my patch? I don't > have write access to the repository, as far as I know. > > Christoph Feck wrote: > me.

Jenkins build became unstable: kde-runtime_stable #600

2014-10-29 Thread KDE CI System
See

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Frank Schütte
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 29, 2014, 1:56 p.m.) Status -- This change has been ma

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Thomas Lübking
> On Okt. 29, 2014, 12:02 nachm., Helio Castro wrote: > > Ok, way better than the previous one :-) > > Frank Schütte wrote: > Thanks for your approval. Now who is going to commit my patch? I don't > have write access to the repository, as far as I know. > > Christoph Feck wrote: > me.

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Christoph Feck
> On Oct. 29, 2014, 12:02 p.m., Helio Castro wrote: > > Ok, way better than the previous one :-) > > Frank Schütte wrote: > Thanks for your approval. Now who is going to commit my patch? I don't > have write access to the repository, as far as I know. me. I am just not sure to which branch

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

2014-10-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120781/ --- (Updated Oct. 29, 2014, 1:28 p.m.) Status -- This change has been ma

Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782/ --- (Updated Oct. 29, 2014, 1:28 p.m.) Status -- This change has been ma

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Frank Schütte
> On Okt. 29, 2014, 12:02 nachm., Helio Castro wrote: > > Ok, way better than the previous one :-) Thanks for your approval. Now who is going to commit my patch? I don't have write access to the repository, as far as I know. - Frank --

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-29 Thread Helio Castro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/#review69425 --- Ship it! Ok, way better than the previous one :-) - Helio Ca

Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-29 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782/#review69404 --- +1 after fixing this last issue. konqueror/CMakeLists.txt

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

2014-10-29 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120781/#review69382 --- Ship it! Ship It! keditbookmarks/CMakeLists.txt