Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 11:37 p.m.) Review request for kdelibs, Solid, Ch

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

> On Oct. 28, 2014, 8:09 p.m., Frank Schütte wrote: > > I'm not familiar with the policies. I resolved the raised issues, so should > > I review my own request or is this something stupid? > > Thomas Lübking wrote: > You're not supposed to approve your own patches (but if nobody ever feels

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 28, 2014, 11:05 p.m., Hrvoje Senjan wrote: > > forward port, for interested ones -> > > https://git.reviewboard.kde.org/r/120876/ Thank you, Hrvoje, you are a gentleman and a scholar... and I am happy to have been able to help... :-) - Ian

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review69367 --- forward port, for interested ones -> https://git.reviewboard.k

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

> On Okt. 28, 2014, 8:09 nachm., Frank Schütte wrote: > > I'm not familiar with the policies. I resolved the raised issues, so should > > I review my own request or is this something stupid? You're not supposed to approve your own patches (but if nobody ever feels in charge to approve it, "no

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/#review69337 --- Ship it! I'm not familiar with the policies. I resolved the r

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

> On Okt. 28, 2014, 2:59 nachm., Thomas Lübking wrote: > > solid-device-automounter/kded/DeviceAutomounter.cpp, line 76 > > > > > > unrelated to this patch, but i'd like to raise: > > > > "wtf does the fu

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Okt. 28, 2014, 7:50 nachm.) Review request for kdelibs, Solid an

Re: Gerrit: merging feature branches

On Dienstag, 28. Oktober 2014 19:13:53 CEST, Marco Martin wrote: Hi all, Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. Google reply: https://wiki.openstack.org/wiki/Gerrit_Workflow#Long-lived_Topic_Branch

Re: Gerrit: merging feature branches

On Tuesday 28 October 2014, Marco Martin wrote: > > in the end the nearest i could get is > https://gerrit.vesnicky.cesnet.cz/r/#/c/130 and don't think that one is really usable, since it generated a review request per commit. -- Marco Martin

Gerrit: merging feature branches

Hi all, Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. now i tried the following 3 approaches, that all fail miserably: * from my branch: git push gerrit HEAD:refs/for/master gives [remote rejected] master -

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120781/ --- (Updated Oct. 28, 2014, 4:24 p.m.) Review request for KDE Base Apps. Ch

Re: Review Request 120782: Allow stand-alone build of konqueror

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782/ --- (Updated Oct. 28, 2014, 4:22 p.m.) Review request for KDE Base Apps. Ch

Re: Review Request 120782: Allow stand-alone build of konqueror

> On Oct. 24, 2014, 10:09 p.m., Christophe Giboudeaux wrote: > > konqueror/CMakeLists.txt, line 32 > > > > > > should be merged with line 22 or 24 if it's optional It cannot, because KDED framework does not insta

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/#review69293 --- Aside the minor WS issues, this patch looks correct and *requi

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 11:43 a.m.) Review request for kdelibs, Solid and

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 11:36 a.m.) Review request for kdelibs, Solid and

Re: [cmake-developers] Severe behavioural change regressions in release branch

On Tue, Oct 28, 2014 at 09:58:58 +1300, Ben Cooksley wrote: > If anyone is interested, help would be appreciated to get a Contracts > style build up and running. > In particular, pointers to documentation on how to perform such builds > would be appreciated - we'll need to run "make install" for pa

Re: Review Request 103815: Add yet another code generation option for having invokable methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103815/#review69240 --- What happened to this? It stalled because of the request for a