Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

2014-10-19 Thread Emmanuel Pescosta
> On Oct. 20, 2014, 1:28 a.m., David Faure wrote: > > filenamesearch/kio_filenamesearch.cpp, line 135 > > > > > > Wow, won't this be really slow? which "remote" protocols is it > > typically used with? Any? Well

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120460/#review68733 --- OK this wasn't too long, I reviewed it directly. It's even bet

Re: Question about QSslCipher::protocolString

2014-10-19 Thread Thiago Macieira
On Sunday 19 October 2014 18:14:36 Thomas Lübking wrote: > On Sonntag, 19. Oktober 2014 16:35:35 CEST, Dawit A wrote: > > protocolString: SSLv3 > > ... > > However if one uses openssl directly, the following information is > > returned: > > > > $ openssl s_client -connect blog.mozilla.org:443 > >

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

2014-10-19 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/ --- (Updated Oct. 19, 2014, 8:45 p.m.) Status -- This change has been ma

Re: Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

2014-10-19 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/ --- (Updated Oct. 19, 2014, 8:44 p.m.) Status -- This change has been ma

Re: Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

2014-10-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/#review68714 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 19, 2014, 2

Re: Question about QSslCipher::protocolString

2014-10-19 Thread Thomas Lübking
On Sonntag, 19. Oktober 2014 16:35:35 CEST, Dawit A wrote: protocolString: SSLv3 ... However if one uses openssl directly, the following information is returned: $ openssl s_client -connect blog.mozilla.org:443 New, TLSv1/SSLv3, Cipher is DHE-RSA-AES128-SHA ... So the negotiated protocol when

Question about QSslCipher::protocolString

2014-10-19 Thread Dawit A
Both the protocol and protocolString methods in QSslCipher return a different value than what is expected. For example, in Qt 4.8 if you set the protocol in QSslSocket to QSsl::TlsV1 and connect to blog.mozilla.org port 443, you get the following output from QSslCipher: QSslSocket Information: ===

Re: Detect window manager using KWindowSystem

2014-10-19 Thread Thomas Lübking
On Sonntag, 19. Oktober 2014 15:08:51 CEST, Martin Gräßlin wrote: Might be worth adding it: bool NETRootInfo::isCompliantWindowManagerRunning() const? It certainly won't harm, but the question is: who actually needs such? WM's operate on the WM selection - and right now, i cannot imagine why

Re: Re: Detect window manager using KWindowSystem

2014-10-19 Thread Martin Gräßlin
On Saturday 18 October 2014 15:34:53 Thomas Lübking wrote: > You MUST check the hinted support window anyway, because if the WM was > killed -9 or -11 it will unlikely (in case of -9 "no way") have withdrawn > any root property and your findings based upon this data alone would be > wrong. > > The

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

2014-10-19 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118313/ --- (Updated Oct. 19, 2014, 12:57 p.m.) Status -- This change has been d

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review68692 --- I think this misses the "remember url as defaultStartDir and u

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-10-19 Thread Simon Bachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/ --- (Updated Oct. 19, 2014, 9:18 a.m.) Status -- This change has been ma

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review68690 --- Ship it! Sorry for the delay -- too many review requests

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118313/#review68689 --- Obsoleted by https://git.reviewboard.kde.org/r/120650/ (and by

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68687 --- kioslave/trash/CMakeLists.txt