Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Hrvoje Senjan
> On Oct. 19, 2014, 2:49 a.m., Hrvoje Senjan wrote: > > interfaces/kompareinterface.h, line 25 > > > > > > this include is also provided by KDELibs4Support.. > > > > quick grep shows it was also left in i

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Jeremy Whiting
Good point, I've posted another review that fixes this. On Sat, Oct 18, 2014 at 6:49 PM, Hrvoje Senjan wrote: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120627/ >interfaces/kompareinterface.h >

Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

2014-10-18 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/ --- Review request for kdelibs and Kevin Kofler. Repository: kompare Descri

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68684 --- interfaces/kompareinterface.h

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- (Updated Oct. 18, 2014, 10:13 p.m.) Status -- This change has been m

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68677 --- Ship it! Looks good now. - Kevin Kofler On Okt. 18, 2014,

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- (Updated Oct. 18, 2014, 3:03 p.m.) Review request for kdelibs and Kevin K

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-10-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Oct. 18, 2014, 8:45 p.m.) Review request for KDE Software on Mac

Re: QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

2014-10-18 Thread Kevin Kofler
Alex Merry wrote: > Could you add this to the porting guide, please? Done, also added KUrl::prettyUrl → QUrl::toDisplayString as per the other thread. Kevin Kofler

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-18 Thread René J . V . Bertin
> On Oct. 14, 2014, 11:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 1043 > > > > > > such a debug statement is more useful if it prints out the input to the > > method, i.e. "topdir". > >

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 18, 2014, 8:08 p.m.) Review request for KDE Software on Mac

Re: Using Gerrit for code review in KDE

2014-10-18 Thread Jan Kundrát
On Thursday, 16 October 2014 23:43:00 CEST, Kevin Kofler wrote: In Gerrit, I basically get an ugly command-line interface: I have to push to a magic ref encoding all the information (and IIRC, git-cola only lets me enter the basic refs/for/branchname, the special characters in stuff like %r=f.

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-18 Thread David Faure
> On oct. 18, 2014, 9:28 matin, David Faure wrote: > > Almost there :-) > > > > Re your earlier comments: > > - trashimpl.h is completely internal to the kioslave, adding methods there > > is no problem > > - trashForMountPoint is called when trashing a file that is on a different > > partitio

Re: Detect window manager using KWindowSystem

2014-10-18 Thread Thomas Lübking
On Freitag, 17. Oktober 2014 14:56:16 CEST, Paulo Lieuthier wrote: I'm now trying to check if there is an active window manager, for lxqt-session. That's what I'm doing: NETRootInfo rootInfo(QX11Info::connection(), NET::Supported); qDebug() << "SupportingWMCheck: " << rootInfo.isSu

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68660 --- komparepart/kompare_part.cpp

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Kevin Kofler
> On Okt. 18, 2014, 4:40 vorm., Kevin Kofler wrote: > > komparepart/kompare_part.cpp, line 303 > > > > > > So where does this temporary file get deleted? Apparently nowhere. > > > > You have to handle th

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-18 Thread René J . V . Bertin
> On Oct. 18, 2014, 11:28 a.m., David Faure wrote: > > Almost there :-) > > > > Re your earlier comments: > > - trashimpl.h is completely internal to the kioslave, adding methods there > > is no problem > > - trashForMountPoint is called when trashing a file that is on a different > > partitio

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

2014-10-18 Thread Emmanuel Pescosta
> On Oct. 18, 2014, 12:01 p.m., David Faure wrote: > > you say it's a port, but it reads like new code (no diff). Is that because > > it moved to another module? Makes reviewing a bit harder (though not > > impossible). > Is that because it moved to another module? I copy-pasted the code to k

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

2014-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120460/#review68652 --- you say it's a port, but it reads like new code (no diff). Is

Detect window manager using KWindowSystem

2014-10-18 Thread Paulo Lieuthier
Hello again, here I'm again trying to use KWindowSystem to the benefit of LXQt. Thanks for KF5! =D I'm now trying to check if there is an active window manager, for lxqt-session. That's what I'm doing: NETRootInfo rootInfo(QX11Info::connection(), NET::Supported); qDebug() << "Supporting

Re: Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

2014-10-18 Thread Andrea Iacovitti
url.toDisplayString() should be equivalent to call url.toString(QUrl::RemovePassword) Andrea

Re: kdepimlibs Coverity Scan Report, Oct 14 2014

2014-10-18 Thread Luca Beltrame
Gilles Caulier wrote: > If you look opensource projects scanned by Coverity, you will seen all > most important on the world. But let's not forget, it is non-Free software. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

2014-10-18 Thread Andrea Iacovitti
url.toDisplayString() should be equivalent to call url.toString(QUrl::RemovePassword) Andrea

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68648 --- Almost there :-) Re your earlier comments: - trashimpl.h is c

Re: QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

2014-10-18 Thread Alex Merry
On Saturday 18 October 2014 02:39:27 Kevin Kofler wrote: > Sorry for yet another self-reply, but I'll point out that Okular currently > uses the two-argument form, which according to the documentation is enough > when only existing files need to be supported, but I definitely recommend > passing th