Re: Review Request 120627: Remove kdelibs4support.

> On Oct. 17, 2014, 10:40 p.m., Kevin Kofler wrote: > > komparepart/kompare_part.cpp, line 303 > > > > > > So where does this temporary file get deleted? Apparently nowhere. > > > > You have to handle th

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- (Updated Oct. 17, 2014, 11:01 p.m.) Review request for kdelibs and Kevin

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- (Updated Oct. 17, 2014, 10:50 p.m.) Review request for kdelibs and Kevin

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68642 --- > I wonder about the Qt 5.4 check though. This version of komp

Re: Review Request 120627: Remove kdelibs4support.

> On Oct. 17, 2014, 4:12 p.m., Kevin Kofler wrote: > > komparepart/kompare_part.cpp, line 295 > > > > > > This line looks very wrong to me: You're executing the block only if > > the stat job failed? This needs

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- (Updated Oct. 17, 2014, 9:40 p.m.) Review request for kdelibs and Kevin K

Re: QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

PS: I wrote: > So, Lukáš Tinkl answered me on #fedora-kde IRC. For posterity: > * Qt 5.4 introduces a new overload: > http://doc-snapshot.qt-project.org/qt5-5.4/qurl.html#fromUserInput-2 > with a third parameter that solves this issue. > * This is how Okular solves the problem without hard-dep

Re: Review Request 120627: Remove kdelibs4support.

> On Okt. 17, 2014, 10:12 nachm., Kevin Kofler wrote: > > main.cpp, line 132 > > > > > > I think this now needs something like: > > QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : > > QU

Re: Review Request 120627: Remove kdelibs4support.

> On Okt. 17, 2014, 10:12 nachm., Kevin Kofler wrote: > > main.cpp, line 132 > > > > > > I think this now needs something like: > > QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : > > QU

Re: QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

Hi, I wrote: > even after reading the porting guide and listening to David Faure's > Akademy talk, I am still unsure about what the best way is to get a URL > from a string, supporting: > * absolute URL (with explicit scheme:// only) > * absolute local file path > * relative path: everything neith

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68636 --- Since the KVBox issue should be fixed in revision 2, I'm lifti

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/#review68635 --- Ship it! I'm approving this one, but please only push it when

QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

Hi, even after reading the porting guide and listening to David Faure's Akademy talk, I am still unsure about what the best way is to get a URL from a string, supporting: * absolute URL (with explicit scheme:// only) * absolute local file path * relative path: everything neither an absolute URL

Re: Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

I wrote: > just a small public service announcement: The correct replacement for: > url.prettyUrl() > in Qt 5 is NOT: > url.toString() // BAD! > but: > url.toString(QUrl::RemovePassword) or, even better: url.toDisplayString() as pointed out by Andrea Iacovitti. (I guess his message is pending mode

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68628 --- (Review of revision 1, because you posted revision 2 while I w

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- (Updated Oct. 17, 2014, 3:38 p.m.) Review request for kdelibs and Kevin K

Re: Review Request 120627: Remove kdelibs4support.

> On Oct. 17, 2014, 12:03 p.m., Kevin Kofler wrote: > > > Use QLayout/QFrame instead of KVBox (seems broken though somehow) > > > > Then I suggest you either fix it, or submit only the parts of the port that > > work. > > > > We have time until KF6 to port away from kdelibs4support, that's yea

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/#review68624 --- This one looks OK, but it changes the API, so it needs to go t

Re: Review Request 120627: Remove kdelibs4support.

> On Okt. 17, 2014, 6:03 nachm., Kevin Kofler wrote: > > > Use QLayout/QFrame instead of KVBox (seems broken though somehow) > > > > Then I suggest you either fix it, or submit only the parts of the port that > > work. > > > > We have time until KF6 to port away from kdelibs4support, that's ye

Re: Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68622 --- > Use QLayout/QFrame instead of KVBox (seems broken though som

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/ --- (Updated Oct. 17, 2014, 10:21 a.m.) Review request for kdelibs and Kevin

Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120630/ --- Review request for kdelibs and Kevin Kofler. Repository: libkomparediff2

Review Request 120627: Remove kdelibs4support.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/ --- Review request for kdelibs and Kevin Kofler. Repository: kompare Descri

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > > I am about to publish a general patch, which is aimed a

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

> On set. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > > I am about to publish a general patch, which is aimed at