Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 13, 2014, 5:46 p.m.) Review request for kdelibs and Vavelin

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 13, 2014, 11:20 p.m.) Review request for KDE Software on Ma

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 10:59 p.m., Thomas Lübking wrote: > > kioslave/trash/trashimpl.cpp, line 168 > > > > > > nothing actuallly changed here - if this failed, the following > > "testDir( trashDir + QString::fromL

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 13, 2014, 11:09 p.m.) Review request for KDE Software on Ma

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 13, 2014, 11:02 p.m.) Review request for KDE Software on Ma

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68331 --- kioslave/trash/trashimpl.cpp

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 8:03 p.m., Lamarque Souza wrote: > > kioslave/trash/trashimpl.cpp, line 815 > > > > > > QFile::remove() does not work with directories. You should use > > QDir().rmdir() instead, which only w

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 8:16 p.m., Milian Wolff wrote: > > kioslave/trash/trashimpl.cpp, line 812 > > > > > > why do you try to *delete* something in the check that should figure > > out if something is empty? that

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 13, 2014, 10:42 p.m.) Review request for KDE Software on Ma

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Okt. 13, 2014, 7:31 nachm., Thomas Lübking wrote: > > kioslave/trash/trashimpl.cpp, line 363 > > > > > > why dI assume you want to remove a *trailing* "/KDE.trash"? > > I would not call my login like thi

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 9:31 p.m., Thomas Lübking wrote: > > kioslave/trash/trashimpl.cpp, line 363 > > > > > > why dI assume you want to remove a *trailing* "/KDE.trash"? > > I would not call my login like this,

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Okt. 13, 2014, 6:16 nachm., Milian Wolff wrote: > > kioslave/trash/trashimpl.cpp, line 812 > > > > > > why do you try to *delete* something in the check that should figure > > out if something is empty? tha

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 8:16 p.m., Milian Wolff wrote: > > kioslave/trash/trashimpl.cpp, line 812 > > > > > > why do you try to *delete* something in the check that should figure > > out if something is empty? that

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Okt. 13, 2014, 6:16 nachm., Milian Wolff wrote: > > kioslave/trash/trashimpl.cpp, line 812 > > > > > > why do you try to *delete* something in the check that should figure > > out if something is empty? tha

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68322 --- kioslave/trash/trashimpl.cpp

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 8:16 p.m., Milian Wolff wrote: > > kioslave/trash/trashimpl.cpp, line 812 > > > > > > why do you try to *delete* something in the check that should figure > > out if something is empty? that

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68318 --- kioslave/trash/trashimpl.cpp

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 8:03 p.m., Lamarque Souza wrote: > > kioslave/trash/trashimpl.cpp, line 815 > > > > > > QFile::remove() does not work with directories. You should use > > QDir().rmdir() instead, which only w

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 13, 2014, 6:03 p.m., Lamarque Souza wrote: > > kioslave/trash/trashimpl.cpp, line 815 > > > > > > QFile::remove() does not work with directories. You should use > > QDir().rmdir() instead, which only w

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68315 --- kioslave/trash/trashimpl.cpp

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 13, 2014, 7:32 p.m.) Review request for KDE Software on Mac

Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- Review request for KDE Software on Mac OS X and KDE Runtime. Repository:

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120460/ --- (Updated Oct. 13, 2014, 3:35 p.m.) Review request for kde-workspace and D