Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > drkonqi/bugzillalib.cpp, line 81 > > > > > > The patch largely consists of hand-crafted version handling. > > > > replacing this by "int version = K

Re: kompare, libkomparediff2 and KDE Applications 14.12

On Thu, Oct 9, 2014 at 12:13 AM, Albert Astals Cid wrote: > El Dijous, 9 d'octubre de 2014, a les 00:12:03, Aleix Pol va escriure: > > On Wed, Oct 8, 2014 at 11:48 PM, Jeremy Whiting > wrote: > > > K, sounds like we've agreed then, libkomparediff2 frameworks branch > > > wont merge to master unt

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 9, 2014, 12:06 a.m.) Review request for KDE Software on Mac

kdelibs coding style.

Hey all, In updating some frameworks I took a look at the kdelibs coding style (Is there a frameworks coding style, if not maybe it should be created?) and especially the Qt Includes section seems a bit backwards from what I see in actual code in frameworks. https://techbase.kde.org/Policies/Kdeli

Re: SDDM-KCM In Review

David, I cloned the git repo here, and built it and installed it next to my other kf5 stuff. (The README still mentions kde4-config, that probably should be updated btw). It runs ok here, but doesn't work :) Maybe I need to symlink some auth file or dbus file or something, but the kcm's save() met

Re: kompare, libkomparediff2 and KDE Applications 14.12

Aleix, Yes, master is what will be released with KDE Applications 14.12 so it needs to stay qt4 based for now since kompare itself will be in this upcoming release. BR, Jeremy On Wed, Oct 8, 2014 at 4:14 PM, Kevin Kofler wrote: > On Thursday 09 October 2014 at 00:12:03, Aleix Pol wrote: >> I do

Re: kompare, libkomparediff2 and KDE Applications 14.12

On Thursday 09 October 2014 at 00:12:03, Aleix Pol wrote: > I don't think one is related to the other. > > master should probably be the development branch already. I don't think we should put stuff in master that is not ready to be branched for release. It's only going to complicate the branchi

Re: kompare, libkomparediff2 and KDE Applications 14.12

El Dijous, 9 d'octubre de 2014, a les 00:12:03, Aleix Pol va escriure: > On Wed, Oct 8, 2014 at 11:48 PM, Jeremy Whiting wrote: > > K, sounds like we've agreed then, libkomparediff2 frameworks branch > > wont merge to master until some time after 14.12 is tagged and such. > > > > If I find a few

Re: kompare, libkomparediff2 and KDE Applications 14.12

On Wed, Oct 8, 2014 at 11:48 PM, Jeremy Whiting wrote: > K, sounds like we've agreed then, libkomparediff2 frameworks branch > wont merge to master until some time after 14.12 is tagged and such. > > If I find a few minutes I'll take a look at improving the api and such > as Aleix noted. > > BR,

Re: Review Request 120535: attica: Add const to getter methods.

> On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: Review Request 120535: attica: Add const to getter methods.

> On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: kompare, libkomparediff2 and KDE Applications 14.12

K, sounds like we've agreed then, libkomparediff2 frameworks branch wont merge to master until some time after 14.12 is tagged and such. If I find a few minutes I'll take a look at improving the api and such as Aleix noted. BR, Jeremy On Wed, Oct 8, 2014 at 3:25 PM, Kevin Kofler wrote: > Hi Ale

Re: Review Request 120535: attica: Add const to getter methods.

> On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: kompare, libkomparediff2 and KDE Applications 14.12

Hi Aleix, hi everyone, On Wednesday 08 October 2014 at 22:08:58, Aleix Pol wrote: > I think we're aiming for 2nd quarter of 2015, it depends a lot on when we > manage to have a sprint I'd say. Things are going forward, but there's > still work to be done. So that will likely be after the next App

Re: Review Request 120535: attica: Add const to getter methods.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68095 --- According to https://techbase.kde.org/Policies/Binary_Compati

Re: Review Request 120535: attica: Add const to getter methods.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- (Updated Oct. 8, 2014, 3:20 p.m.) Review request for KDE Frameworks, kdel

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

Aleix Pol ha scritto: > On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid > wrote: > > El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: > > On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer > mailto:thomas.pfeif...@kde.org>> > > > > wro

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

El Dimecres, 8 d'octubre de 2014, a les 22:23:44, Aleix Pol va escriure: > On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid wrote: > > El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: > > > On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer > > > > > wrote: > > > > On Sunda

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid wrote: > El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: > > On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer > > > > > wrote: > > > On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: > > > > > The reasoning is th

Re: kompare, libkomparediff2 and KDE Applications 14.12

On Tue, Oct 7, 2014 at 11:59 PM, Jeremy Whiting wrote: > Kevin, Others, > > Libkomparediff2 has been ported to kf5 for quite some time, kdevelop > or kdevplatform frameworks based code (not sure if it's master or > frameworks branches) uses it and it seems to work ok there. I wonder > when we sho

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: > On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer > > wrote: > > On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: > > > > The reasoning is that this way they will be released together with > > > > Plasma > > > >

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer wrote: > On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: > > > The reasoning is that this way they will be released together with > Plasma > > > Workspace. > > > > I don't see that anyone can have a problem with kde-gtk-config. > > Riski

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

> On Oct. 8, 2014, 1:47 p.m., Christoph Feck wrote: > > To get changes into Qt, you directly create the review requests on the > > qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction > > Christoph Feck wrote: > Ignore that comment... :P Ok. Or rather, I'll jump on the occa

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

> On Oct. 8, 2014, 11:47 a.m., Christoph Feck wrote: > > To get changes into Qt, you directly create the review requests on the > > qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction Ignore that comment... :P - Christoph -

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120528/#review68076 --- To get changes into Qt, you directly create the review request

Review Request 120529: [OS X] avoid crash when calling invalidateBuffer_resizeHelper on parentless widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120529/ --- Review request for KDE Software on Mac OS X and Qt KDE. Repository: qt

Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120528/ --- Review request for KDE Software on Mac OS X and Qt KDE. Repository: qt