Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-04 Thread Ian Wadham
> On Oct. 5, 2014, 2:06 a.m., Ben Cooksley wrote: > > drkonqi/bugzillalib.cpp, line 161 > > > > > > Perhaps use kWarning() or kDebug() instead? Done. > On Oct. 5, 2014, 2:06 a.m., Ben Cooksley wrote: > > drkon

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-04 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 5, 2014, 4:27 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-04 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67943 --- drkonqi/bugzillalib.cpp

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

2014-10-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120195/ --- (Updated Oct. 4, 2014, 11:20 p.m.) Status -- This change has been ma

SDDM-KCM In Review

2014-10-04 Thread David Edmundson
Hey all, I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now starting the mandatory review period. It's a config module for configuring SDDM, the Display Manager. Mostly themes and autologin, plus some misc options. The final destination will be workspace. Application histor

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-10-04 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/#review67927 --- See also bug 334174 - Marko Käning On Sept. 25, 2014, 3:32

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

2014-10-04 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120195/#review67915 --- shell/mainwindow_p.cpp

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

2014-10-04 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120195/#review67912 --- Ship it! Ship It! - Milian Wolff On Sept. 25, 2014, 2:06 p

Re: Fwd: PVS-Studio KDE analysis

2014-10-04 Thread Boris Egorov
On 10/02/2014 04:45 PM, Ben Cooksley wrote: > > Okay, can you confirm whether we're allowed to publish this publicly or not? > > Thanks, > Ben > Svyatoslav said yes, we're allowed to do this. -- Best regards, Boris Egorov

Re: Moving repositories in the module structure

2014-10-04 Thread Víctor Blázquez
I'm sorry for doing the move that fast, I should have realized it was sent only to plasma-devel Víctor Blázquez On Fri, Oct 3, 2014 at 12:04 AM, Aleix Pol wrote: > On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley wrote: > >> Hi all, >> >> It seems there has been a recent outbreak of repository mo

Re: Moving repositories in the module structure

2014-10-04 Thread Ben Cooksley
On Fri, Oct 3, 2014 at 2:28 PM, Aleix Pol wrote: > On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid wrote: >> >> El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure: >> > On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley wrote: >> > > Hi all, >> > > >> > > It seems there has be

Re: Moving repositories in the module structure

2014-10-04 Thread Ben Cooksley
On Fri, Oct 3, 2014 at 11:33 AM, Víctor Blázquez wrote: > I'm sorry for doing the move that fast, I should have realized it was sent > only to plasma-devel No worries - in virtually all cases it is fine to process requests when we receive them. > > Víctor Blázquez Thanks, Ben > > On Fri, Oct 3