Re: Review Request 120439: kio_webdav: Fix folder creation on apache + mod_dav webdav server

2014-09-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120439/ --- (Updated Oct. 1, 2014, 5:15 a.m.) Status -- This change has been mar

Re: Review Request 113413: Improved Keyboard Layout Preview

2014-09-30 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 1, 2014, 2:59 a.m.) Status -- This change has been mar

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-30 Thread Thomas Lübking
> On Sept. 28, 2014, 3:13 nachm., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 220 > > > > > > mehhh: branched exits. > > René J.V. Bertin wrote: > you realise that the 2 exits don't return t

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-30 Thread René J . V . Bertin
> On Sept. 28, 2014, 5:13 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 220 > > > > > > mehhh: branched exits. > > René J.V. Bertin wrote: > you realise that the 2 exits don't return the

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-30 Thread Thomas Lübking
> On Sept. 28, 2014, 3:13 nachm., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 220 > > > > > > mehhh: branched exits. > > René J.V. Bertin wrote: > you realise that the 2 exits don't return t

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120403/ --- (Updated Sept. 30, 2014, 10:42 p.m.) Review request for KDE Software on M

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-30 Thread René J . V . Bertin
> On Sept. 28, 2014, 5:13 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 220 > > > > > > mehhh: branched exits. you realise that the 2 exits don't return the exact same kind of symbol? Using

Review Request 120439: kio_webdav: Fix folder creation on apache + mod_dav webdav server

2014-09-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120439/ --- Review request for kdelibs. Bugs: 322550 http://bugs.kde.org/show_bug

Re: Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120418/ --- (Updated Sept. 30, 2014, 11:41 a.m.) Review request for kdelibs. Bugs:

Re: Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120418/ --- (Updated Sept. 30, 2014, 11:39 a.m.) Review request for kdelibs. Change

Re: Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120418/ --- (Updated Sept. 30, 2014, 11:06 a.m.) Review request for kdelibs. Change

Re: libkface

2014-09-30 Thread Gilles Caulier
2014-09-30 11:57 GMT+02:00 David Edmundson : > > > On Tue, Sep 30, 2014 at 11:38 AM, Gilles Caulier > wrote: >> >> 2014-09-30 11:28 GMT+02:00 Martin Klapetek : >> > On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier >> > >> > wrote: >> >> >> >> 2014-09-30 3:06 GMT+02:00 Vishesh Handa : >> >> > Hey T

Re: libkface

2014-09-30 Thread David Edmundson
On Tue, Sep 30, 2014 at 11:38 AM, Gilles Caulier wrote: > 2014-09-30 11:28 GMT+02:00 Martin Klapetek : > > On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier < > caulier.gil...@gmail.com> > > wrote: > >> > >> 2014-09-30 3:06 GMT+02:00 Vishesh Handa : > >> > Hey Tobias > >> > > >> > Some comments abo

Re: libkface

2014-09-30 Thread David Edmundson
On Sat, Sep 27, 2014 at 1:39 PM, Gilles Caulier wrote: > 2014-09-27 12:59 GMT+02:00 David Edmundson : > > Please make sure to add license headers on all files in libkface before > > release. There seem to be a lot missing. > > Hum, which one ? > My bad, the script licensecheck is failing on the

Re: libkface

2014-09-30 Thread Gilles Caulier
2014-09-30 11:28 GMT+02:00 Martin Klapetek : > On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier > wrote: >> >> 2014-09-30 3:06 GMT+02:00 Vishesh Handa : >> > Hey Tobias >> > >> > Some comments about the code - >> > >> > 1. The code seems to be licensed under GPL. In order to make it into a >> > fra

Re: libkface

2014-09-30 Thread Martin Klapetek
On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier wrote: > 2014-09-30 3:06 GMT+02:00 Vishesh Handa : > > Hey Tobias > > > > Some comments about the code - > > > > 1. The code seems to be licensed under GPL. In order to make it into a > > framework, it will need to be re-licensed. This library seems

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-09-30 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67658 --- drkonqi/bugzillalib.h

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-09-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67656 --- Great, it's been ... bugging me that the bug reporter hasn't b

Re: libkface

2014-09-30 Thread Gilles Caulier
2014-09-30 7:44 GMT+02:00 Gilles Caulier : > 2014-09-30 3:06 GMT+02:00 Vishesh Handa : >> Hey Tobias >> >> Some comments about the code - >> >> 1. The code seems to be licensed under GPL. In order to make it into a >> framework, it will need to be re-licensed. This library seems like an ideal >> ca

Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-09-30 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- Review request for KDE Software on Mac OS X, KDE Runtime and Ben Cooksley.