Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67470 --- Ship it! Looks good to me, though I can of course not comment

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

On Thursday 25 September 2014 22:32:35 René J.V. Bertin wrote: > Ah, apparently Thiago missed the multiple recent reminders of the fact that > we OS X users are going to be "stuck" in/with KDE4 for a tad longer than > the average Linux user (Debian apart, maybe? ;)) Anyway, I guess I'm going > to h

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120376/ --- (Updated sep. 26, 2014, 4:21 matin) Review request for KDE Runtime. Bug

Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120376/ --- Review request for KDE Runtime. Bugs: 337742 http://bugs.kde.org/show

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 6:07 nachm., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/#review67442 --- Aside Thiagos concern, what actually causes the menubar/docker

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

On Thursday 25 September 2014 13:32:41 René J.V. Bertin wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120363/ > --- > > R

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 25, 2014, 5:58 p.m., Martin Gräßlin wrote: > > kglobalaccel/main.cpp, lines 48-55 > > > > > > now there are two deleted lines... My bad, I could so hardly believe that one might want 2 empty lines ther

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 6:14 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67431 --- kglobalaccel/main.cpp

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 5:22 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67428 --- kglobalaccel/main.cpp

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 25, 2014, 4:10 p.m., Martin Gräßlin wrote: > > kglobalaccel/main.cpp, line 28 > > > > > > it's obvious that the include is needed, otherwise one wouldn't add it. > > I think that comment is not adding

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 4:58 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67423 --- kglobalaccel/main.cpp

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120195/ --- (Updated Sept. 25, 2014, 4:06 p.m.) Review request for KDE Software on Ma

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 25, 2014, 4:03 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 4:02 p.m.) Review request for KDE Software on Ma

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- (Updated Sept. 25, 2014, 4 p.m.) Review request for KDE Base Apps, KDE So

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Sept. 25, 2014, 3:58 p.m.) Review request for KDE Software on Ma

Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdel