Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread Martin Gräßlin
> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread Ian Wadham
> On Sept. 24, 2014, 5:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Updating our tools

2014-09-24 Thread viv...@gmail.com
Il 24/09/2014 16:13, Allen Winter ha scritto: > > Yes that's all on my plate. > I have it on my todo list. > Krazy should be kde5 ready , I just need to plug it in and turn it on. > > I don't recall if there were any blockers, or if I simply got distracted on > something else. > > The associated c

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread Thomas Lübking
> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread Martin Gräßlin
> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) I agree totally, but for that - I'd have to understand exactly wha

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/#review67379 --- I assume you'd be better off altering KMenu::addTitle() - or e

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 24, 2014, 7:23 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67376 --- Please watch coding style and please also have a look at the f

Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- Review request for KDE Base Apps, KDE Software on Mac OS X and kdelibs. R

Re: Updating our tools

2014-09-24 Thread Jeremy Whiting
Allen, Thanks for fixing this, I think it will be a useful tool to check our existing frameworks and code based on frameworks with. I'll update the techbase pages myself. thanks, Jeremy On Wed, Sep 24, 2014 at 8:13 AM, Allen Winter wrote: > On Tuesday, September 23, 2014 04:15:27 PM Jeremy Whit

Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- Review request for KDE Software on Mac OS X, KDE Runtime and kdelibs. Rep

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 24, 2014, 5 p.m.) Review request for KDE Software on Mac O

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-24 Thread Thomas Lübking
> On Sept. 21, 2014, 6:11 nachm., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Updating our tools

2014-09-24 Thread Allen Winter
On Tuesday, September 23, 2014 04:15:27 PM Jeremy Whiting wrote: > Albert, > > I can take a look at it if someone points me in the right direction. I > also found this: > http://ebn.kde.org/krazy/reports/frameworks-5.x/kdelibs/knewstuff/index.html > which seems to check the right way for framework

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-24 Thread Thomas Lübking
> On Sept. 18, 2014, 10:28 nachm., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be i