Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-23 Thread Ian Wadham
> On Sept. 18, 2014, 10:28 p.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-23 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/ --- (Updated Sept. 24, 2014, 1:01 a.m.) Status -- This change has been m

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-23 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/ --- (Updated Sept. 24, 2014, 12:59 a.m.) Status -- This change has been

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-23 Thread René J . V . Bertin
> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Updating our tools

2014-09-23 Thread Jeremy Whiting
Albert, I can take a look at it if someone points me in the right direction. I also found this: http://ebn.kde.org/krazy/reports/frameworks-5.x/kdelibs/knewstuff/index.html which seems to check the right way for frameworks suggestions, but it hasn't been ran since Dec of last year :/ and also it c

Re: Updating our tools

2014-09-23 Thread Albert Astals Cid
El Dimarts, 23 de setembre de 2014, a les 15:56:58, Jeremy Whiting va escriure: > Hello all, > > Since some of our applications and our workspace will be updated for > the next major release (14.12 is the name iirc) to use Qt5 and KDE > Frameworks I thought I would check englishbreakfastnetwork.o

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-23 Thread Thomas Lübking
> On Sept. 21, 2014, 6:11 nachm., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Updating our tools

2014-09-23 Thread Jeremy Whiting
Hello all, Since some of our applications and our workspace will be updated for the next major release (14.12 is the name iirc) to use Qt5 and KDE Frameworks I thought I would check englishbreakfastnetwork.org code checker of kanagram (which has master branch based on qt5 and kf5). http://ebn.kde.

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-23 Thread René J . V . Bertin
> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-23 Thread Christoph Feck
> On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote: > > No problem if we want to discuss it longer, and eventually change icon > > sizes to match text sizes (as is done in Skulpture style) or optionally > > allow configuring icon sizes. > > > > But right now, limiting to a hardcoded 20px val

Re: Review Request 120341: [kde-baseapps] Fix knewmenu ? knewfilemenu include

2014-09-23 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120341/ --- (Updated Sept. 23, 2014, 9:07 p.m.) Status -- This change has been m

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/#review67317 --- Ship it! No problem if we want to discuss it longer, and even

Re: Review Request 120341: [kde-baseapps] Fix knewmenu ? knewfilemenu include

2014-09-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120341/#review67316 --- Ship it! Ship It! - David Faure On Sept. 23, 2014, 8:48 p.

Review Request 120341: [kde-baseapps] Fix knewmenu ? knewfilemenu include

2014-09-23 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120341/ --- Review request for KDE Base Apps and David Faure. Repository: kde-baseapp

Re: KIO slaves: fuse moutned remote filesystems treated as local filesystems.

2014-09-23 Thread Albert Astals Cid
Hi El Dilluns, 22 de setembre de 2014, a les 08:34:48, Euan Thoms va escriure: > My question refers to KDE4 specifically, but may be relevant to KDE5 also. > > I'm using WebDAV for our corporate roll-out via davfs2 (fuse module for > WebDAV). In Dolphin the browsing can be very slow because of 2

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-23 Thread René J . V . Bertin
> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-23 Thread Thomas Lübking
> On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-23 Thread Thomas Lübking
> On Sept. 21, 2014, 6:11 nachm., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2014-09-23 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2014-09-23 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2014-09-23 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https:/

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2014-09-23 Thread René J . V . Bertin
> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-23 Thread Boris Egorov
> On Sept. 9, 2014, 8:02 p.m., Thomas Lübking wrote: > > treeview.cpp, line 232 > > > > > > Maybe rather try to limit to the font height instead? > > Christoph Feck wrote: > Why? We use "Small" icon size nex

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2014-09-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120319/#review67302 --- Qt cannot "distiguish" because there's nothing to distinguish

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-23 Thread Boris Egorov
> On Sept. 9, 2014, 8:02 p.m., Thomas Lübking wrote: > > treeview.cpp, line 232 > > > > > > Maybe rather try to limit to the font height instead? > > Christoph Feck wrote: > Why? We use "Small" icon size nex

KIO slaves: fuse moutned remote filesystems treated as local filesystems.

2014-09-23 Thread Euan Thoms
My question refers to KDE4 specifically, but may be relevant to KDE5 also.I'm using WebDAV for our corporate roll-out via davfs2 (fuse module for WebDAV). In Dolphin the browsing can be very slow because of 2 things:(i) the size column gets populated with number of items within (e.g. recursive list